You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/13 22:32:26 UTC
[jira] [Commented] (NIFI-3350) Reduce NiFi startup time by
streamlining documentation extraction
[ https://issues.apache.org/jira/browse/NIFI-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822458#comment-15822458 ]
ASF GitHub Bot commented on NIFI-3350:
--------------------------------------
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1416
NIFI-3350 optimized documentation extraction to reduce startup time
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mosermw/nifi NIFI-3350
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1416
----
commit 5871d3ecc198ff3f1b449f6c7cdb32391e7bfeb4
Author: Mike Moser <mo...@apache.org>
Date: 2017-01-13T22:17:36Z
NIFI-3350 optimized documentation extraction to reduce startup time
----
> Reduce NiFi startup time by streamlining documentation extraction
> -----------------------------------------------------------------
>
> Key: NIFI-3350
> URL: https://issues.apache.org/jira/browse/NIFI-3350
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 0.7.1, 1.1.1
> Reporter: Michael Moser
> Assignee: Michael Moser
>
> On NiFi startup, after seeing the new log message added in NIFI-3164, I noticed that generating documentation of all components takes a long time. After reading the NarUnpacker code, it appears to scan every file in every jar for NiFi component documentation. I think there are some optimizations we can do here which should reduce NiFi startup time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)