[GitHub] eolivelli commented on a change in pull request #737: Issue 688: add bookkeeper-all package and update notice files

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #737:  Issue 688: add bookkeeper-all package and update notice files
URL: https://github.com/apache/bookkeeper/pull/737#discussion_r151798858
 
 

 ##########
 File path: bookkeeper-server/bin/bookkeeper
 ##########
 @@ -71,13 +71,18 @@ else
 fi
 
 # exclude tests jar
-RELEASE_JAR=$(ls ${BK_HOME}/bookkeeper-server-*.jar 2> /dev/null | grep -v tests | tail -1)
+RELEASE_JAR=$(ls ${BK_HOME}/*bookkeeper-server-*.jar 2> /dev/null | grep -v tests | tail -1)
 
 Review comment:
   If we are changing this script maybe we should write a note on upgrade instructions.
   Maybe people usually replace only the contents of 'lib' directory in order to preserve configuration.
   
   I am not an user of this script I am just asking

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services