[jira] [Commented] (LUCENE-3807) Cleanup suggester API

["Arcadius Ahouansou (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14747320#comment-14747320 ] 

Arcadius Ahouansou commented on LUCENE-3807:
--------------------------------------------

Hi [~simonw]

Sorry for coming late...

{quote}
weight (ie freq) now returns a long instead of a float discouraging floating point number as weights
{quote}

There are many cases like with the {{AnalyzingInfixSuggester}} where the weight is pre-computed outside of Lucene before ingestion.

Having a {{double}} (floating point) makes sense as it would help avoid all sort of rounding/data-loss.


> Cleanup suggester API
> ---------------------
>
>                 Key: LUCENE-3807
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3807
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/other
>    Affects Versions: 3.6, 4.0-ALPHA
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 3.6, 4.0-ALPHA
>
>         Attachments: LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807_3x.patch
>
>
> Currently the suggester api and especially TermFreqIterator don't play that nice with BytesRef and other paradigms we use in lucene, further the java iterator pattern isn't that useful when it gets to work with TermsEnum, BytesRef etc. We should try to clean up this api step by step moving over to BytesRef including the Lookup class and its interface...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org