You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/08/03 22:04:51 UTC
[GitHub] [trafficserver] JosiahWI opened a new pull request, #10148: Move APIHook classes to tsapi
JosiahWI opened a new pull request, #10148:
URL: https://github.com/apache/trafficserver/pull/10148
This is the second of three parts of a refactoring to break out FeatureAPIHooks, making it possible to unit test hook callbacks.
This moves APIHook, APIHooks, and FeatureAPIHooks to tsapi. It also moves the global ssl hooks to inknet, and the global http tooks to proxy. This removes the definitions of all those classes from the various stubs (in inknet, inkcache, and http_remap).
The diff is pretty large, but there are very few source changes. Licenses and includes were added, and the global ssl hooks were renamed from `ssl_hooks` to `g_ssl_hooks`. I also added functions to iocore and proxy to initialize the ssl and http hooks respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #10148: Move APIHook classes to tsapi
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10148:
URL: https://github.com/apache/trafficserver/pull/10148#issuecomment-1673661367
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #10148: Move APIHook classes to tsapi
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10148:
URL: https://github.com/apache/trafficserver/pull/10148#issuecomment-1674971204
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #10148: Move APIHook classes to tsapi
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10148:
URL: https://github.com/apache/trafficserver/pull/10148#issuecomment-1665739431
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move APIHook classes to tsapicore [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen merged PR #10148:
URL: https://github.com/apache/trafficserver/pull/10148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move APIHook classes to tsapi [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10148:
URL: https://github.com/apache/trafficserver/pull/10148#issuecomment-1756089288
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org