[jira] Commented: (DERBY-2941) With 10.2, Closing a resultset after retrieving a large > 32665 bytes value with Network Server does not release locks

["Øystein Grøvlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513224 ] 

Øystein Grøvlen commented on DERBY-2941:
----------------------------------------

I have looked at the patch, and I think the patch looks very good.
I only have some minor comments/questions:

 - Did you intend to leave the changes to DDMWriter in there?

 - You have added a comment that says "Stream is initialized on the
   first read".  It is not quite clear to me what stream you are
   referring to.  It looks to me that the caller has to initialize the
   stream (call initInputStream) BEFORE it is to be read.

 - There seem to be some indentation differences in the
   EXTDTAInputStream constructor.

 - I do not understand the javadoc for EXTDTAInputStream.isNUll.  What
   do you mean by "determined in the constructor"?  It seems like the
   only thing the constructor does is to register the parameter
   values.
  
+1 to commit, but would prefer that the comments discussed about is made clearer.

> With 10.2, Closing a resultset after retrieving a large > 32665 bytes value with Network Server does not release locks
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2941
>                 URL: https://issues.apache.org/jira/browse/DERBY-2941
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.2.2.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>             Fix For: 10.2.2.1
>
>         Attachments: DERBY-2941_diff.txt
>
>
> Making a subtask for the 10.2 fix for this issue as the fix for 10.3 will be different.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.