You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "kiranchavala (via GitHub)" <gi...@apache.org> on 2023/04/05 07:29:22 UTC

[GitHub] [cloudstack] kiranchavala opened a new pull request, #7402: Fixed the Description coloumn in the UI for Quota traffic page

kiranchavala opened a new pull request, #7402:
URL: https://github.com/apache/cloudstack/pull/7402

   ### Description
   
   This PR fixes the description column output in the ui for the quota Tariff page
   
   
   The following PR #5909 changed the response for the  quotaTariffList api call 
   
   https://cloudstack.apache.org/api/apidocs-4.18/apis/quotaTariffList.html
   
   
   In 4.17 the response for the quotaTariffList api call contains the "description" feild
   ```
   
   
   <quotatariff>
   <usageType>1</usageType>
   <usageName>RUNNING_VM</usageName>
   <usageUnit>Compute-Month</usageUnit>
   <usageDiscriminator/>
   <tariffValue>0.00000</tariffValue>
   <effectiveDate>2010-05-04T00:00:00+0000</effectiveDate>
   <description>Running Vm Usage</description>
   <currency>$</currency>
   </quotatariff>
   ```
   
   Screenshot
   
   ![quota2](https://user-images.githubusercontent.com/1401014/230010500-dcee5cb9-86bb-47f1-84ed-26a2d26622ae.png)
   
   In 4.18 the response for the quotaTariffList api call contains the "usageTypeDescription" field due to that there is no response in the Description coloumn
   
   
   ```
   <quotatariff>
   <usageType>1</usageType>
   <usageName>RUNNING_VM</usageName>
   <usageUnit>Compute*Month</usageUnit>
   <usageDiscriminator/>
   <tariffValue>0.00000</tariffValue>
   <effectiveDate>2010-05-04T00:00:00+0000</effectiveDate>
   <usageTypeDescription>Running Vm Usage</usageTypeDescription>
   <currency>$</currency>
   <name>RUNNING_VM</name>
   <uuid>115dca9d-d2a5-11ed-b49d-1e00cd000444</uuid>
   </quotatariff>
   ```
   
   Screenshot
   ![quota1](https://user-images.githubusercontent.com/1401014/230010539-3d30b7e0-99b0-4c3d-9581-bd9b5ec8829f.png)
   
   
   
   Steps to reproduce the issue
   
   1. Enable the "quota.enable.service)" to true
   2. Restart the management server
   3. Go to UI >Quota > Tariff
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### How Has This Been Tested?
   
   Tested on the 4.18 docker simulator
   
   Screenshot
   ![quota3](https://user-images.githubusercontent.com/1401014/230011262-0e733e0f-c856-45c5-9c05-e15fa20d7130.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497399208

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497491716

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7402)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7402&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7402&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7402&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7402&metric=coverage&view=list) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7402&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] kiranchavala commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497049345

   Not able to fix the column Name after making the change 
   
   Need help to fix the Name to Description 
   
   ![quota4](https://user-images.githubusercontent.com/1401014/230012279-2b39394e-1984-41c5-921a-8b76d66a1c69.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] kiranchavala commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497271576

   @shwstppr Done, can you check if I performed the steps correctly, as it's showing 19 commits
   
   I had done only 2 commits


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497414438

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7402 (QA-JID-76)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] kiranchavala commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497215235

   @shwstppr Thanks it working now
   
   ![quota4](https://user-images.githubusercontent.com/1401014/230045666-7345055a-826a-48b8-8dc7-a4ec7a0ac6ed.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497134591

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7402)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7402&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7402&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7402&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7402&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7402&metric=coverage&view=list) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7402&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] codecov[bot] commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497326170

   ## [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#7402](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0cabf0) into [4.18](https://codecov.io/gh/apache/cloudstack/commit/c35d7ac9356e7cdc83a9f1edd57143aee0bc4506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c35d7ac) will **increase** coverage by `0.00%`.
   > The diff coverage is `1.61%`.
   
   > :exclamation: Current head d0cabf0 differs from pull request most recent head b1af980. Consider uploading reports for the commit b1af980 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##               4.18    #7402    +/-   ##
   ==========================================
     Coverage     12.69%   12.69%            
   - Complexity     8661     8669     +8     
   ==========================================
     Files          2717     2718     +1     
     Lines        256169   256359   +190     
     Branches      39928    39967    +39     
   ==========================================
   + Hits          32528    32553    +25     
   - Misses       219506   219669   +163     
   - Partials       4135     4137     +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ck/engine/subsystem/api/storage/VolumeService.java](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9lbmdpbmUvc3Vic3lzdGVtL2FwaS9zdG9yYWdlL1ZvbHVtZVNlcnZpY2UuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...ine/subsystem/api/storage/type/VolumeTypeBase.java](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9lbmdpbmUvc3Vic3lzdGVtL2FwaS9zdG9yYWdlL3R5cGUvVm9sdW1lVHlwZUJhc2UuamF2YQ==) | `10.00% <ø> (ø)` | |
   | [...e/subsystem/api/storage/type/VolumeTypeHelper.java](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9lbmdpbmUvc3Vic3lzdGVtL2FwaS9zdG9yYWdlL3R5cGUvVm9sdW1lVHlwZUhlbHBlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [.../main/java/com/cloud/network/IpAddressManager.java](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2NvbXBvbmVudHMtYXBpL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL25ldHdvcmsvSXBBZGRyZXNzTWFuYWdlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...java/com/cloud/agent/manager/AgentManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvYWdlbnQvbWFuYWdlci9BZ2VudE1hbmFnZXJJbXBsLmphdmE=) | `4.77% <0.00%> (-0.17%)` | :arrow_down: |
   | [...n/java/com/cloud/vm/VmWorkJobWakeupDispatcher.java](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvdm0vVm1Xb3JrSm9iV2FrZXVwRGlzcGF0Y2hlci5qYXZh) | `0.00% <ø> (ø)` | |
   | [.../cloud/configuration/dao/ResourceCountDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9jb25maWd1cmF0aW9uL2Rhby9SZXNvdXJjZUNvdW50RGFvSW1wbC5qYXZh) | `8.84% <ø> (ø)` | |
   | [...in/java/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9kYy9kYW8vQ2x1c3RlclZTTU1hcERhb0ltcGwuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...in/java/com/cloud/dc/dao/DomainVlanMapDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9kYy9kYW8vRG9tYWluVmxhbk1hcERhb0ltcGwuamF2YQ==) | `54.54% <ø> (ø)` | |
   | [...main/java/com/cloud/dc/dao/VlanDetailsDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9kYy9kYW8vVmxhbkRldGFpbHNEYW9JbXBsLmphdmE=) | `0.00% <ø> (ø)` | |
   | ... and [56 more](https://codecov.io/gh/apache/cloudstack/pull/7402?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/cloudstack/pull/7402/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] kiranchavala commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497216162

   @shwstppr shall i retarget this fix to 4.18 branch ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497233114

   @kiranchavala yes, that would be better since backend changes are there in 4.18


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud merged pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497186073

   > Not able to fix the column Name after making the change
   > 
   > Need help to fix the Name to Description
   > 
   > ![quota4](https://user-images.githubusercontent.com/1401014/230012279-2b39394e-1984-41c5-921a-8b76d66a1c69.png)
   
   @kiranchavala add a key in `ui/public/locales/en.json`,
   ```
   "label.usageTypeDescription": "Usage description",
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] github-code-scanning[bot] commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497491932

   You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository [Security tab](/apache/cloudstack/security/code-scanning?query=pr%3A7402+tool%3ASonarCloud+is%3Aopen).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7402: Fixed the Description coloumn in the UI for Quota traffic page

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7402:
URL: https://github.com/apache/cloudstack/pull/7402#issuecomment-1497399545

   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org