You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by Jean-Louis MONTEIRO <je...@atosorigin.com> on 2008/11/24 18:08:26 UTC

Web application not well deployed

Hi all,

I'm using openejb 3.1 embedded in tomcat 5.5.17.
Deploying an application <Context docBase="path to webapp" path="/sample" />
works fine.
Using an empty path (ie. path="") can provide some unpredicted behavior
(injection in servlets, ...).

May be TomcatWebAppBuilder of the openejb-tomcat-catalina module can be
enhanced.
I've noticed some lines
166: standardContext.setPath("/" + webApp.contextRoot);
255: if (("/" + w.contextRoot).equals(standardContext.getPath())) {
339: if (("/" + webAppInfo.contextRoot).equals(standardContext.getPath())) {

that should be changed to accept empty path.

Any comment ?
Can I open a JIRA ?
I will have a look into TomcatWebAppBuilder (deeper) to submit a patch if
you want.

Regards,
Jean-Louis
-- 
View this message in context: http://www.nabble.com/Web-application-not-well-deployed-tp20665147p20665147.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: [JIRA OPENEJB-975]Re: Web application not well deployed

Posted by Jonathan Gallimore <jo...@gmail.com>.

I opened a Jira issue: OPENEJB-997 for this and have committed this 
patch in revision 739591. Please let me know if there's any problems. 
Thanks for the patch Werni.

Regards

Jon

Jonathan Gallimore wrote:
> I've been having the same issue defining a custom realm in a 
> context.xml file which wasn't getting passed to Tomcat:
>
> <Context>
> <Realm className="org.apache.catalina.realm.JAASRealm"
>          appName="MyLoginRealm"
>          userClassNames="uk.me.jrg.app.Principal"
>          roleClassNames="uk.me.jrg.app.Group"
>          debug="99"
>          useContextClassLoader="true" />
>
> </Context>
>
>
> I tried doing this change in TomcatWebAppBuilder:
>
> Index: 
> assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatWebAppBuilder.java
> ===================================================================
> --- 
> assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatWebAppBuilder.java    
> (revision 735837)
> +++ 
> assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatWebAppBuilder.java    
> (working copy)
> @@ -162,7 +162,14 @@
>          for (WebAppInfo webApp : appInfo.webApps) {
>              if (getContextInfo(webApp) == null) {
>                  StandardContext standardContext = new StandardContext();
> -                standardContext.addLifecycleListener(new 
> ContextConfig());
> +                String contextXmlFile = webApp.codebase + 
> "/META-INF/context.xml";
> +                if (new File(contextXmlFile).exists()) {
> +                    standardContext.setConfigFile(contextXmlFile);
> +                    standardContext.setOverride(true);
> +                }
> +                ContextConfig contextConfig = new ContextConfig();
> +                standardContext.addLifecycleListener(contextConfig);
> +
>                  standardContext.setPath("/" + webApp.contextRoot);
>                  standardContext.setDocBase(webApp.codebase);
>                  standardContext.setParentClassLoader(classLoader);
>
>
> which worked for me - would this work for you too?
>
> Does anyone else have an opinion on this change? I'm quite happy to 
> file a JIRA and get it committed.
>
> Cheers
>
> Jon
>
>
> werni wrote:
>> Hi,
>>
>> I have a similar problem with TomcatWebAppBuilder which is related to
>> user-defined contexts:
>>
>> In the method
>>
>> public void deployWebApps(AppInfo appInfo, ClassLoader classLoader);
>>
>> the standardContext is initialized as follows:
>>
>> if (getContextInfo(webApp) == null) {
>>     StandardContext standardContext = new StandardContext();
>>     standardContext.addLifecycleListener(new ContextConfig());
>>     standardContext.setPath("/" + webApp.contextRoot);
>>     standardContext.setDocBase(webApp.codebase);
>>     standardContext.setParentClassLoader(classLoader);
>>     standardContext.setDelegate(true);
>>
>> The problem in my opinion is the line
>>
>> standardContext.addLifecycleListener(new ContextConfig());
>>
>> i.e. the standardContext is initialized with an empty ContextConfig. If a
>> context.xml is defined for a WebApp (located in one of the standard places,
>> conf/Catalina/<host>/, META-INF/context.xml, ...) it is ignored. This is
>> very undesirable if a context.xml defines Resources, ...
>>
>> With the following hack the ContextConfig is initialized with
>> META-INF/context.xml:
>>
>> StandardContext standardContext = new StandardContext();
>> standardContext.setConfigFile(
>>     webApp.codebase + "/META-INF/context.xml"
>> );
>> WebAppContextConfig.initContext(standardContext);
>> standardContext.setPath("/" + webApp.contextRoot);
>> standardContext.setDocBase(webApp.codebase);
>> standardContext.setParentClassLoader(classLoader);
>> standardContext.setDelegate(true);
>>
>> and the helper class
>>
>> private static class WebAppContextConfig extends ContextConfig {
>>
>>     private void init(
>>         StandardContext standardContext
>>     ) {
>>         standardContext.addLifecycleListener(this);
>>         this.context = standardContext;
>>         boolean tmpOverride = standardContext.getOverride();
>>         standardContext.setOverride(true);
>>         this.contextConfig();            
>>         standardContext.setOverride(tmpOverride);
>>     }
>>     
>>     public static void initContext(
>>         StandardContext standardContext
>>     ) {
>>         WebAppContextConfig config = new WebAppContextConfig();
>>         config.init(standardContext);
>>     }
>>             
>> }
>>
>> Of course this is far from a clean solution. Any comments?
>>
>> Rgs,
>> -werni.
>>
>>
>>
>>
>>
>>

Re: [JIRA OPENEJB-975]Re: Web application not well deployed

Posted by Jonathan Gallimore <jo...@gmail.com>.

I've been having the same issue defining a custom realm in a context.xml 
file which wasn't getting passed to Tomcat:

<Context>
<Realm className="org.apache.catalina.realm.JAASRealm"
         appName="MyLoginRealm"
         userClassNames="uk.me.jrg.app.Principal"
         roleClassNames="uk.me.jrg.app.Group"
         debug="99"
         useContextClassLoader="true" />

</Context>


I tried doing this change in TomcatWebAppBuilder:

Index: 
assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatWebAppBuilder.java
===================================================================
--- 
assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatWebAppBuilder.java    
(revision 735837)
+++ 
assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatWebAppBuilder.java    
(working copy)
@@ -162,7 +162,14 @@
         for (WebAppInfo webApp : appInfo.webApps) {
             if (getContextInfo(webApp) == null) {
                 StandardContext standardContext = new StandardContext();
-                standardContext.addLifecycleListener(new ContextConfig());
+                String contextXmlFile = webApp.codebase + 
"/META-INF/context.xml";
+                if (new File(contextXmlFile).exists()) {
+                    standardContext.setConfigFile(contextXmlFile);
+                    standardContext.setOverride(true);
+                }
+                ContextConfig contextConfig = new ContextConfig();
+                standardContext.addLifecycleListener(contextConfig);
+
                 standardContext.setPath("/" + webApp.contextRoot);
                 standardContext.setDocBase(webApp.codebase);
                 standardContext.setParentClassLoader(classLoader);


which worked for me - would this work for you too?

Does anyone else have an opinion on this change? I'm quite happy to file 
a JIRA and get it committed.

Cheers

Jon


werni wrote:
> Hi,
>
> I have a similar problem with TomcatWebAppBuilder which is related to
> user-defined contexts:
>
> In the method
>
> public void deployWebApps(AppInfo appInfo, ClassLoader classLoader);
>
> the standardContext is initialized as follows:
>
> if (getContextInfo(webApp) == null) {
>     StandardContext standardContext = new StandardContext();
>     standardContext.addLifecycleListener(new ContextConfig());
>     standardContext.setPath("/" + webApp.contextRoot);
>     standardContext.setDocBase(webApp.codebase);
>     standardContext.setParentClassLoader(classLoader);
>     standardContext.setDelegate(true);
>
> The problem in my opinion is the line
>
> standardContext.addLifecycleListener(new ContextConfig());
>
> i.e. the standardContext is initialized with an empty ContextConfig. If a
> context.xml is defined for a WebApp (located in one of the standard places,
> conf/Catalina/<host>/, META-INF/context.xml, ...) it is ignored. This is
> very undesirable if a context.xml defines Resources, ...
>
> With the following hack the ContextConfig is initialized with
> META-INF/context.xml:
>
> StandardContext standardContext = new StandardContext();
> standardContext.setConfigFile(
>     webApp.codebase + "/META-INF/context.xml"
> );
> WebAppContextConfig.initContext(standardContext);
> standardContext.setPath("/" + webApp.contextRoot);
> standardContext.setDocBase(webApp.codebase);
> standardContext.setParentClassLoader(classLoader);
> standardContext.setDelegate(true);
>
> and the helper class
>
> private static class WebAppContextConfig extends ContextConfig {
>
>     private void init(
>         StandardContext standardContext
>     ) {
>         standardContext.addLifecycleListener(this);
>         this.context = standardContext;
>         boolean tmpOverride = standardContext.getOverride();
>         standardContext.setOverride(true);
>         this.contextConfig();            
>         standardContext.setOverride(tmpOverride);
>     }
>     
>     public static void initContext(
>         StandardContext standardContext
>     ) {
>         WebAppContextConfig config = new WebAppContextConfig();
>         config.init(standardContext);
>     }
>             
> }
>
> Of course this is far from a clean solution. Any comments?
>
> Rgs,
> -werni.
>
>
>
>
>
>

Re: [JIRA OPENEJB-975]Re: Web application not well deployed

Posted by werni <wf...@omex.ch>.

Hi,

I have a similar problem with TomcatWebAppBuilder which is related to
user-defined contexts:

In the method

public void deployWebApps(AppInfo appInfo, ClassLoader classLoader);

the standardContext is initialized as follows:

if (getContextInfo(webApp) == null) {
    StandardContext standardContext = new StandardContext();
    standardContext.addLifecycleListener(new ContextConfig());
    standardContext.setPath("/" + webApp.contextRoot);
    standardContext.setDocBase(webApp.codebase);
    standardContext.setParentClassLoader(classLoader);
    standardContext.setDelegate(true);

The problem in my opinion is the line

standardContext.addLifecycleListener(new ContextConfig());

i.e. the standardContext is initialized with an empty ContextConfig. If a
context.xml is defined for a WebApp (located in one of the standard places,
conf/Catalina/<host>/, META-INF/context.xml, ...) it is ignored. This is
very undesirable if a context.xml defines Resources, ...

With the following hack the ContextConfig is initialized with
META-INF/context.xml:

StandardContext standardContext = new StandardContext();
standardContext.setConfigFile(
    webApp.codebase + "/META-INF/context.xml"
);
WebAppContextConfig.initContext(standardContext);
standardContext.setPath("/" + webApp.contextRoot);
standardContext.setDocBase(webApp.codebase);
standardContext.setParentClassLoader(classLoader);
standardContext.setDelegate(true);

and the helper class

private static class WebAppContextConfig extends ContextConfig {

    private void init(
        StandardContext standardContext
    ) {
        standardContext.addLifecycleListener(this);
        this.context = standardContext;
        boolean tmpOverride = standardContext.getOverride();
        standardContext.setOverride(true);
        this.contextConfig();            
        standardContext.setOverride(tmpOverride);
    }
    
    public static void initContext(
        StandardContext standardContext
    ) {
        WebAppContextConfig config = new WebAppContextConfig();
        config.init(standardContext);
    }
            
}

Of course this is far from a clean solution. Any comments?

Rgs,
-werni.





-- 
View this message in context: http://www.nabble.com/Web-application-not-well-deployed-tp20665147p21567349.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.