You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/18 13:21:36 UTC

[GitHub] [flink] godfreyhe opened a new pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource

godfreyhe opened a new pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource
URL: https://github.com/apache/flink/pull/8782
 
 
   
   
   ## What is the purpose of the change
   
   *Introduce planner rule to push filter into TableSource*
   
   ## Brief change log
   
     - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
     - *Deployments RPC transmits only the blob storage reference*
     - *TaskManagers retrieve the TaskInfo from the blob cache*
   
     - *Added PushFilterIntoTableSourceScanRule that pushes filter into TableSource*
     - *Added RexNodeExtractor to extract conjunctive predicates to Expressions*
   
   
   ## Verifying this change
   
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (100MB)*
     - *Extended integration test for recovery after master (JobManager) failure*
     - *Added test that validates that TaskInfo is transferred only once across recoveries*
     - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
   
     - *Added PushFilterIntoTableSourceScanRuleTest that validates logical plan after PushFilterIntoTableSourceScanRule is applied*
     - *Added TableSourceTest that validates the physical plan for the filterable table source*
     - *Added TableSourceITCase that validates the execution result for the filterable table source*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services