You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by afs <gi...@git.apache.org> on 2017/10/13 14:27:51 UTC
[GitHub] jena pull request #288: JENA-1401 (fuseki backup) Don't use Jetty code in wa...
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/288
JENA-1401 (fuseki backup) Don't use Jetty code in war servlets.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena jena-1401-fuseki-backup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #288
----
commit c991ae41362f7fb44380d3722c72bee8e3941fad
Author: Andy Seaborne <an...@apache.org>
Date: 2017-10-13T14:13:18Z
Put back jena-spatial into -Pdev for build stability
commit 57951c902e0f8a8c5567c6dd0f4d1ba72e3ea0d7
Author: Andy Seaborne <an...@apache.org>
Date: 2017-10-13T14:16:48Z
JENA-1401: Use JDK-provided thread-safe set.
----
---
[GitHub] jena pull request #288: JENA-1401 (fuseki backup) Don't use Jetty code in wa...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/288#discussion_r144571831
--- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/async/AsyncPool.java ---
@@ -51,7 +51,13 @@ public AsyncTask submit(Runnable task, String displayName, DataService dataServi
synchronized(mutex) {
String taskId = Long.toString(++counter) ;
Fuseki.serverLog.info(format("Task : %s : %s",taskId, displayName)) ;
- Callable<Object> c = Executors.callable(task) ;
+ Callable<Object> c = ()->{
+ try { task.run(); }
+ catch (Throwable th) {
+ Fuseki.serverLog.warn(format("Exception in task %s execution", taskId), th);
--- End diff --
Does this qualify as an error? (Logging-wise)
---
[GitHub] jena pull request #288: JENA-1401 (fuseki backup) Don't use Jetty code in wa...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/288#discussion_r144586550
--- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/async/AsyncPool.java ---
@@ -51,7 +51,13 @@ public AsyncTask submit(Runnable task, String displayName, DataService dataServi
synchronized(mutex) {
String taskId = Long.toString(++counter) ;
Fuseki.serverLog.info(format("Task : %s : %s",taskId, displayName)) ;
- Callable<Object> c = Executors.callable(task) ;
+ Callable<Object> c = ()->{
+ try { task.run(); }
+ catch (Throwable th) {
+ Fuseki.serverLog.warn(format("Exception in task %s execution", taskId), th);
--- End diff --
Maybe. It is a development bug!
---
[GitHub] jena pull request #288: JENA-1401 (fuseki backup) Don't use Jetty code in wa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/288
---