[jira] [Commented] (LUCENE-8290) Keep soft deletes in sync with on-disk DocValues

["Simon Willnauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461106#comment-16461106 ] 

Simon Willnauer commented on LUCENE-8290:
-----------------------------------------

[~mikemccand] can you take a look

> Keep soft deletes in sync with on-disk DocValues
> ------------------------------------------------
>
>                 Key: LUCENE-8290
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8290
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>
>         Attachments: LUCENE-8290.patch
>
>
> Today we pass on the doc values update to the PendingDeletes
>     when it's applied. This might cause issues with a rentention policy
>     merge policy that will see a deleted document but not it's value on
>     disk.
>     This change moves back the PendingDeletes callback to flush time
>     in order to be consistent with what is actually updated on disk.
>     
>     This change also makes sure we write values to disk on flush that
>     are in the reader pool as well as extra best effort checks to drop
>     fully deleted segments on flush, commit and getReader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org