You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/08/27 02:31:45 UTC
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14146
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
IMPALA-8895: Expose daemon health endpoint
This change exposes the daemon health of an impalad via an HTTP endpoint
'/healthz'. If the server is healthy, this endpoint will return HTTP
code 200 (OK). If it is unhealthy, it will return 503 (Service
Unavailable). With this change, the endpoint is equivalent to the
'impala-server.ready' metric.
Testing: I added a test in test_web_pages.py and observed manually that
the endpoint returns 503 while starting up.
Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
---
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/metrics.cc
M be/src/util/metrics.h
M be/src/util/webserver.cc
M be/src/util/webserver.h
M tests/webserver/test_web_pages.py
9 files changed, 47 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/14146/1
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4394/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 19:05:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG@13
PS1, Line 13: 'impala-server.ready' metric.
> One thing I didn't think about was authentication - is it gonna be messy en
Thats a good point. Do you think we should add a webserver in this patch or defer to a subsequent change?
An alternative might be to pull some callbacks inside BeginRequestCallback() in front of HandleSpnego() and skip authentication checks (/healthz should be fine for any user to access).
http://gerrit.cloudera.org:8080/#/c/14146/1/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:
http://gerrit.cloudera.org:8080/#/c/14146/1/be/src/service/impala-http-handler.cc@179
PS1, Line 179: (*data) << "OK";
> It feels wrong to me that we're not setting *response - I guess the caller
Done
http://gerrit.cloudera.org:8080/#/c/14146/1/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/14146/1/tests/webserver/test_web_pages.py@658
PS1, Line 658:
> flake8: W391 blank line at end of file
Done
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 15:57:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 3: Code-Review+2
Updated call signature in one test. Carrying Tim's +2.
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 18:57:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14146
to look at the new patch set (#2).
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
IMPALA-8895: Expose daemon health endpoint
This change exposes the daemon health of an impalad via an HTTP endpoint
'/healthz'. If the server is healthy, this endpoint will return HTTP
code 200 (OK). If it is unhealthy, it will return 503 (Service
Unavailable). With this change, the endpoint is equivalent to the
'impala-server.ready' metric.
Testing: I added a test in test_web_pages.py and observed manually that
the endpoint returns 503 while starting up.
Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
---
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/metrics.cc
M be/src/util/metrics.h
M be/src/util/webserver.cc
M be/src/util/webserver.h
M tests/webserver/test_web_pages.py
9 files changed, 47 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/14146/2
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
IMPALA-8895: Expose daemon health endpoint
This change exposes the daemon health of an impalad via an HTTP endpoint
'/healthz'. If the server is healthy, this endpoint will return HTTP
code 200 (OK). If it is unhealthy, it will return 503 (Service
Unavailable). With this change, the endpoint is equivalent to the
'impala-server.ready' metric.
Testing: I added a test in test_web_pages.py and observed manually that
the endpoint returns 503 while starting up.
Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Reviewed-on: http://gerrit.cloudera.org:8080/14146
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/metrics.cc
M be/src/util/metrics.h
M be/src/util/webserver-test.cc
M be/src/util/webserver.cc
M be/src/util/webserver.h
M tests/webserver/test_web_pages.py
10 files changed, 49 insertions(+), 7 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/4390/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 16:31:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 4: Verified+1 Code-Review+2
Rebased to decouple from the change for IMPALA-8892. Carrying Tim's +2 and Jenkins's Verified.
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 23:49:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/4378/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 03:13:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG@13
PS1, Line 13: 'impala-server.ready' metric.
One thing I didn't think about was authentication - is it gonna be messy enabling authentication if everything that's running health checks (kubernetes, etc) has to be able to authenticate with the web server?
If we think that's going to be a problem, maybe we should be starting a second unauthenticated webserver with just this endpoint.
http://gerrit.cloudera.org:8080/#/c/14146/1/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:
http://gerrit.cloudera.org:8080/#/c/14146/1/be/src/service/impala-http-handler.cc@179
PS1, Line 179: (*data) << "OK";
It feels wrong to me that we're not setting *response - I guess the caller is initialising it but it seems brittle.
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 03:38:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14146/1/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/14146/1/tests/webserver/test_web_pages.py@658
PS1, Line 658:
flake8: W391 blank line at end of file
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 02:32:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4860/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 18:58:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 23:01:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14146
to look at the new patch set (#3).
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
IMPALA-8895: Expose daemon health endpoint
This change exposes the daemon health of an impalad via an HTTP endpoint
'/healthz'. If the server is healthy, this endpoint will return HTTP
code 200 (OK). If it is unhealthy, it will return 503 (Service
Unavailable). With this change, the endpoint is equivalent to the
'impala-server.ready' metric.
Testing: I added a test in test_web_pages.py and observed manually that
the endpoint returns 503 while starting up.
Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
---
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/metrics.cc
M be/src/util/metrics.h
M be/src/util/webserver-test.cc
M be/src/util/webserver.cc
M be/src/util/webserver.h
M tests/webserver/test_web_pages.py
10 files changed, 49 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/14146/3
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
I'm OK with proceeding as-is and dealing with the authentication in a follow-on change.
http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG@13
PS1, Line 13: 'impala-server.ready' metric.
> Thats a good point. Do you think we should add a webserver in this patch or
I think the second alternative sounds better if we can do it cleanly (it looks like the webserver accesses a lot of global flags).
--
To view, visit http://gerrit.cloudera.org:8080/14146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615
Gerrit-Change-Number: 14146
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 17:23:08 +0000
Gerrit-HasComments: Yes