You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ra...@apache.org on 2019/05/22 08:38:27 UTC
[sling-org-apache-sling-scripting-core] 02/03: SLING-8425 - NPE in
SlingScriptEngineManager when Sling is run on GraalVM
This is an automated email from the ASF dual-hosted git repository.
radu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-scripting-core.git
commit 11d59c1d8dba37fc4090057ca96b11f0853374a7
Author: Paul Bjorkstrand <pa...@gmail.com>
AuthorDate: Mon May 20 16:19:58 2019 -0500
SLING-8425 - NPE in SlingScriptEngineManager when Sling is run on GraalVM
* add else case/logging to the script engine registration loops
---
.../sling/scripting/core/impl/jsr223/SlingScriptEngineManager.java | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/main/java/org/apache/sling/scripting/core/impl/jsr223/SlingScriptEngineManager.java b/src/main/java/org/apache/sling/scripting/core/impl/jsr223/SlingScriptEngineManager.java
index b5f800a..fe7b425 100644
--- a/src/main/java/org/apache/sling/scripting/core/impl/jsr223/SlingScriptEngineManager.java
+++ b/src/main/java/org/apache/sling/scripting/core/impl/jsr223/SlingScriptEngineManager.java
@@ -295,16 +295,22 @@ public class SlingScriptEngineManager extends ScriptEngineManager implements Bun
for (String extension : factory.getExtensions()) {
if (extension != null && !extension.isEmpty()) {
internalManager.registerEngineExtension(extension, factory);
+ } else {
+ LOG.warn("Could not register an empty or null extension for script engine factory {}", factory.getEngineName());
}
}
for (String mimeType : factory.getMimeTypes()) {
if (mimeType != null && !mimeType.isEmpty()) {
internalManager.registerEngineMimeType(mimeType, factory);
+ } else {
+ LOG.warn("Could not register an empty or null mime type for script engine factory {}", factory.getEngineName());
}
}
for (String name : factory.getNames()) {
if (name != null && !name.isEmpty()) {
internalManager.registerEngineName(name, factory);
+ } else {
+ LOG.warn("Could not register an empty or null engine name for script engine factory {}", factory.getEngineName());
}
}
}