You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/28 14:47:46 UTC

[GitHub] [flink] XComp opened a new pull request, #21411: [FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

XComp opened a new pull request, #21411:
URL: https://github.com/apache/flink/pull/21411

   1.16 backport PR for parent PR #21252


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

Posted by GitBox <gi...@apache.org>.
XComp merged PR #21411:
URL: https://github.com/apache/flink/pull/21411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21411:
URL: https://github.com/apache/flink/pull/21411#issuecomment-1329242699

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "072be544b53c4de81c2864cb56378df928a07fb5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "072be544b53c4de81c2864cb56378df928a07fb5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 072be544b53c4de81c2864cb56378df928a07fb5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21411:
URL: https://github.com/apache/flink/pull/21411#issuecomment-1333684866

   > Or didn't you base the external repository on `apache/flink:master`? 🤔
   
   Correct, because `master` has a breaking change in 1.17 (see https://issues.apache.org/jira/browse/FLINK-28853). So the sync was based on `release-1.16`, that's now being released as 3.0. When that release is completed, we'll merge https://github.com/apache/flink-connector-pulsar/pull/2 which contains the remaining changes between `release-1.16` and `master`. That can only be released when Flink 1.17 is released and will be released as 4.0. 
   
   This is the only way we can get the Pulsar connector code out of `apache/flink:master` during the 1.17 release cycle. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21411:
URL: https://github.com/apache/flink/pull/21411#issuecomment-1333645254

   But what's puzzling me now. Shouldn't that change already be in the external repository? Or didn't you base the external repository on `apache/flink:master`? :thinking: 
   
   The original change made it to `apache/flink:master` with PR #21252 20 days ago.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21411:
URL: https://github.com/apache/flink/pull/21411#issuecomment-1333408169

   @MartijnVisser there is no `v3.0` branch in [apache/flink-connector-pulsar]( https://github.com/apache/flink-connector-pulsar)(,yet?). :thinking: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21411:
URL: https://github.com/apache/flink/pull/21411#issuecomment-1333487912

   Meh it's fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21411:
URL: https://github.com/apache/flink/pull/21411#issuecomment-1330159487

   @syhily can you have a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily commented on pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

Posted by GitBox <gi...@apache.org>.
syhily commented on PR #21411:
URL: https://github.com/apache/flink/pull/21411#issuecomment-1334672389

   This LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21411:
URL: https://github.com/apache/flink/pull/21411#issuecomment-1332715705

   @XComp Can you please also create this backport to https://github.com/apache/flink-connector-pulsar ? It should be target towards to the v3.0 branch there. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21411:
URL: https://github.com/apache/flink/pull/21411#issuecomment-1333752687

   thanks for clarification :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org