You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2023/08/10 12:17:10 UTC

[GitHub] [camel] orpiske commented on a diff in pull request #11061: CAMEL-19518: replaced Thread.sleep() in camel-disruptor tests

orpiske commented on code in PR #11061:
URL: https://github.com/apache/camel/pull/11061#discussion_r1290036188


##########
components/camel-disruptor/src/test/java/org/apache/camel/component/disruptor/SedaDisruptorCompareTest.java:
##########
@@ -232,7 +233,7 @@ void speedTestDisruptor(
         System.out.println("Starting real test of: " + componentName);
 
         forceGC();
-        Thread.sleep(1000);
+        Awaitility.await().atMost(1, TimeUnit.SECONDS);

Review Comment:
   This is missing the actual check to performed. Probably you need to put `untilAsserted` or something like that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org