You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/10 18:23:07 UTC
[GitHub] [airflow] potiuk opened a new pull request #19523: Disable test code coverage for PRs
potiuk opened a new pull request #19523:
URL: https://github.com/apache/airflow/pull/19523
The test code coverage took a lot of memory (2-3GB) when core
tests were running (specifically test_kubernetes_executor.py) and
the memory was kept for the duration of whole test.
This caused intermittent memory issues on public GitHub runners.
The change only uses test coverage for `main` builds where we have
a lot of memory available.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19523: Disable test code coverage for PRs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19523:
URL: https://github.com/apache/airflow/pull/19523#issuecomment-965623003
cc: @khalidmammadov @o-nikolas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19523: Disable test code coverage for PRs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19523:
URL: https://github.com/apache/airflow/pull/19523#issuecomment-965626245
I REALLY hope this one will solve the memory errors for contributors now ! :crossed_fingers:
I reproducibly run the `test_kubermetes.py` followed by `test_backfill_job.py` with/without coverage yielding 2-3 GB vs 700 MB memory used while test_backfill_job was running. So I REALLY hope it's gonna fly this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19523: Disable test code coverage for PRs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19523:
URL: https://github.com/apache/airflow/pull/19523#issuecomment-965770263
It failed for a different reason in one test - but I do think it's gonna work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19523: Disable test code coverage for PRs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19523:
URL: https://github.com/apache/airflow/pull/19523#issuecomment-965624729
And "regular" user PR here: https://github.com/apache/airflow/pull/19524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19523: Disable test code coverage for PRs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19523:
URL: https://github.com/apache/airflow/pull/19523#issuecomment-965638401
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19523: Disable test code coverage for PRs
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19523:
URL: https://github.com/apache/airflow/pull/19523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org