You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "shraymoza (via GitHub)" <gi...@apache.org> on 2025/03/24 07:35:14 UTC
[PR] encapsulating to avoid Deficient Encapsulation [commons-lang]
shraymoza opened a new pull request, #1363:
URL: https://github.com/apache/commons-lang/pull/1363
encapsulating to avoid Deficient Encapsulation
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated!
Before you push a pull request, review this list:
- [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] encapsulating to avoid Deficient Encapsulation [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1363:
URL: https://github.com/apache/commons-lang/pull/1363#issuecomment-2747920571
Hello @shraymoza
-1: This looks to me like change for the sake of change.
If you would like to help the project:
- Look at Jira tickets for bugs to fix
- Fix the failing test(s) on Java 23 and up
Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] encapsulating to avoid Deficient Encapsulation [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #1363: encapsulating to avoid Deficient Encapsulation
URL: https://github.com/apache/commons-lang/pull/1363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] encapsulating to avoid Deficient Encapsulation [commons-lang]
Posted by "aherbert (via GitHub)" <gi...@apache.org>.
aherbert commented on PR #1363:
URL: https://github.com/apache/commons-lang/pull/1363#issuecomment-2747213572
Removing a public field will break binary compatibility. Note that the field is **final** and encapsulation is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org