[jira] [Commented] (SOLR-13473) Ensure that the tests use JSON,javabin to update docs

["David Smiley (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18052295#comment-18052295 ] 

David Smiley commented on SOLR-13473:
-------------------------------------

Looking back at this, I only think that assertU should be considered deprecated, as it takes an XML string which is a terrible developer-experience from a method signature standpoint.

Looking ahead to more SolrClient usage... we don't need much; maybe nothing.  {{client().add(sdoc("id", "my-id"))}} is very simple.  The underlying format is irrelevant/invisible.  Many assertU callers could be updated in a machine/automated way (IntelliJ "structural replace") if we end up with widespread use of a client(), say.

> Ensure that the tests use JSON,javabin to update docs
> -----------------------------------------------------
>
>                 Key: SOLR-13473
>                 URL: https://issues.apache.org/jira/browse/SOLR-13473
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Priority: Major
>
> {{SolrTestCaseJ4#assertU}} sends documents as XML. XML is a very uncommon update format .
> We should change it to use JSON/javabin 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org