You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2024/02/21 15:57:10 UTC
[PR] Modified SuspendedTabletsIT to confirm suspension cleared [accumulo]
dlmarion opened a new pull request, #4286:
URL: https://github.com/apache/accumulo/pull/4286
Tablet suspension marker in Tablet metadata is cleared on a subsequent tablet unload
Closes #3314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified SuspendedTabletsIT to confirm suspension cleared [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #4286:
URL: https://github.com/apache/accumulo/pull/4286#discussion_r1499697323
##########
test/src/main/java/org/apache/accumulo/test/manager/SuspendedTabletsIT.java:
##########
@@ -322,6 +325,20 @@ private void suspensionTestBody(TServerKiller serverStopper) throws Exception {
Thread.sleep(1000);
ds = TabletLocations.retrieve(ctx, tableName);
}
+
Review Comment:
I was able to reproduce your log information. Looking now at where `deleteSuspension` is called, it's being called in `MetadataStateStore.setFutureLocations` and `MetadataStateStore.setLocations`. The changes to this test likely don't need to be merged. Also, I think #3314 can be closed without changes as the code in the description is not reflective of the current state of the code now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified SuspendedTabletsIT to confirm suspension cleared [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #4286:
URL: https://github.com/apache/accumulo/pull/4286#issuecomment-1960171113
I talked with @keith-turner . He is working on a different PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified SuspendedTabletsIT to confirm suspension cleared [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion closed pull request #4286: Modified SuspendedTabletsIT to confirm suspension cleared
URL: https://github.com/apache/accumulo/pull/4286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified SuspendedTabletsIT to confirm suspension cleared [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #4286:
URL: https://github.com/apache/accumulo/pull/4286#issuecomment-1960305181
OPened #4295. Was finally able to figure out the mystery around #3314 because of [this comment](https://github.com/apache/accumulo/blob/f2adaebba28b5e47ea03a850254e901a0c7be371/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L333) plus where the comment fell in the code. At the place where comment fell a tablets goal state is !HOSTED and its current state is SUSPENDED. So that lead me to suspect the intent of the code was to clear suspend markers for offline tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified SuspendedTabletsIT to confirm suspension cleared [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #4286:
URL: https://github.com/apache/accumulo/pull/4286#discussion_r1499653719
##########
test/src/main/java/org/apache/accumulo/test/manager/SuspendedTabletsIT.java:
##########
@@ -322,6 +325,20 @@ private void suspensionTestBody(TServerKiller serverStopper) throws Exception {
Thread.sleep(1000);
ds = TabletLocations.retrieve(ctx, tableName);
}
+
Review Comment:
Interesting, I'll look into this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified SuspendedTabletsIT to confirm suspension cleared [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4286:
URL: https://github.com/apache/accumulo/pull/4286#discussion_r1499546610
##########
test/src/main/java/org/apache/accumulo/test/manager/SuspendedTabletsIT.java:
##########
@@ -322,6 +325,20 @@ private void suspensionTestBody(TServerKiller serverStopper) throws Exception {
Thread.sleep(1000);
ds = TabletLocations.retrieve(ctx, tableName);
}
+
Review Comment:
I currently am in the process of trying to understand this test. While doing so I added the following at this loacation and ran it locally.
```java
log.info("hc:{} sc:{} ac:{}", ds.hostedCount, ds.suspendedCount, ds.assignedCount);
```
I am seeing this output the following. So even before the tablet server is stopped the suspend count is already zero.
```
hc:30 sc:0 ac:0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org