You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/03/30 12:54:11 UTC

Review Request 32616: LENS-440 : ColumnarSQLRewriter.rewrite should not be synchronized

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32616/
-----------------------------------------------------------

Review request for lens and Jaideep dhok.


Bugs: LENS-440
    https://issues.apache.org/jira/browse/LENS-440


Repository: lens


Description
-------

Removes the rewriterCache in JDBCDriver.


Diffs
-----

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java d5dc9a3 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 121b56b 

Diff: https://reviews.apache.org/r/32616/diff/


Testing
-------

Tests in lens-jdbc-driver passes. Waiting full test run.


Thanks,

Amareshwari Sriramadasu


Re: Review Request 32616: LENS-440 : ColumnarSQLRewriter.rewrite should not be synchronized

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32616/
-----------------------------------------------------------

(Updated March 30, 2015, 11:09 a.m.)


Review request for lens and Jaideep dhok.


Bugs: LENS-440
    https://issues.apache.org/jira/browse/LENS-440


Repository: lens


Description
-------

Removes the rewriterCache in JDBCDriver.


Diffs
-----

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java d5dc9a3 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 121b56b 

Diff: https://reviews.apache.org/r/32616/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.196s]
[INFO] Lens .............................................. SUCCESS [1.856s]
[INFO] Lens API .......................................... SUCCESS [5.736s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.029s]
[INFO] Lens Cube ......................................... SUCCESS [2:36.489s]
[INFO] Lens DB storage ................................... SUCCESS [10.590s]
[INFO] Lens Query Library ................................ SUCCESS [4.646s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:41.605s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [18.778s]
[INFO] Lens Server ....................................... SUCCESS [6:34.284s]
[INFO] Lens client ....................................... SUCCESS [21.420s]
[INFO] Lens CLI .......................................... SUCCESS [2:50.966s]
[INFO] Lens Examples ..................................... SUCCESS [0.790s]
[INFO] Lens Distribution ................................. SUCCESS [9.073s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:01.555s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.477s]
[INFO] Lens Regression ................................... SUCCESS [0.482s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:10.860s
[INFO] Finished at: Mon Mar 30 11:09:06 UTC 2015
[INFO] Final Memory: 108M/1064M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 32616: LENS-440 : ColumnarSQLRewriter.rewrite should not be synchronized

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32616/#review78195
-----------------------------------------------------------

Ship it!


Ship It!

- Jaideep dhok


On March 30, 2015, 10:54 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32616/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 10:54 a.m.)
> 
> 
> Review request for lens and Jaideep dhok.
> 
> 
> Bugs: LENS-440
>     https://issues.apache.org/jira/browse/LENS-440
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Removes the rewriterCache in JDBCDriver.
> 
> 
> Diffs
> -----
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java d5dc9a3 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 121b56b 
> 
> Diff: https://reviews.apache.org/r/32616/diff/
> 
> 
> Testing
> -------
> 
> Tests in lens-jdbc-driver passes. Waiting full test run.
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>