[jira] [Commented] (LUCENE-3623) SegmentReader.getFieldNames ignores FieldOption.DOC_VALUES

["Robert Muir (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164068#comment-13164068 ] 

Robert Muir commented on LUCENE-3623:
-------------------------------------

also on a general note, i don't like how we don't test this addIndexes(FIR) stuff very well, and i don't like the FieldOption api 
that it uses for this, its really just a duplicate of the FieldInfos api in my opinion.

long term I think we should:
# somehow test this better by doing addIndexes(SlowMultiReaderWrapper(segment), ...) behind the scenes in RandomIndexWriter?
# maybe in 4.0 try to clean up FieldInfos and have IR return it, nuking this FieldOption API so that we dont have "two different ways we merge" ?
                
> SegmentReader.getFieldNames ignores FieldOption.DOC_VALUES
> ----------------------------------------------------------
>
>                 Key: LUCENE-3623
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3623
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3623_test.patch
>
>
> we use this getFieldNames api in segmentmerger if we merge something that isn't a SegmentReader (e.g. FilterIndexReader)
> it looks to me that if you use a FilterIndexReader, call addIndexes(Reader...) the docvalues will be simply dropped.
> I dont think its enough to just note that the field has docvalues either right? We need to also set the type 
> correctly in the merged field infos? This would imply that instead of FieldOption.DOCVALUES, we need to have a 
> FieldOption for each ValueType so that we correctly update the type.
> But looking at FI.update/setDocValues, it doesn't look like we 'type-promote' here anyway?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org