You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2015/08/04 21:15:16 UTC
Review Request 37092: Modify the gradle build to optionally prefix
CLASSPATH with a custom value when running installDist.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37092/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-1425
https://issues.apache.org/jira/browse/AURORA-1425
Repository: aurora
Description
-------
Modify the gradle build to optionally prefix CLASSPATH with a custom value when running installDist.
This enables much greater iteration speed when working on the Aurora UI.
Diffs
-----
build.gradle fa2e268047bfb4ad41f41e0c9e423ddb53ceb02d
docs/developing-aurora-scheduler.md 17cfc183cfc5e9359df800e983d8bb45d70d4f9b
examples/vagrant/aurorabuild.sh 8850e9382f4192873fe2d785e75a7d73403696d6
Diff: https://reviews.apache.org/r/37092/diff/
Testing
-------
Verified that I'm able to reload the UI in vagrant and have it pick up changes without restarting/rebuilding the scheduler.
Thanks,
Joshua Cohen
Re: Review Request 37092: Modify the gradle build to optionally prefix
CLASSPATH with a custom value when running installDist.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37092/#review94106
-----------------------------------------------------------
Ship it!
Master (7fdcfef) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 4, 2015, 7:15 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37092/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 7:15 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1425
> https://issues.apache.org/jira/browse/AURORA-1425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Modify the gradle build to optionally prefix CLASSPATH with a custom value when running installDist.
>
> This enables much greater iteration speed when working on the Aurora UI.
>
>
> Diffs
> -----
>
> build.gradle fa2e268047bfb4ad41f41e0c9e423ddb53ceb02d
> docs/developing-aurora-scheduler.md 17cfc183cfc5e9359df800e983d8bb45d70d4f9b
> examples/vagrant/aurorabuild.sh 8850e9382f4192873fe2d785e75a7d73403696d6
>
> Diff: https://reviews.apache.org/r/37092/diff/
>
>
> Testing
> -------
>
> Verified that I'm able to reload the UI in vagrant and have it pick up changes without restarting/rebuilding the scheduler.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 37092: Modify the gradle build to optionally prefix
CLASSPATH with a custom value when running installDist.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37092/#review94119
-----------------------------------------------------------
Ship it!
Nice!
examples/vagrant/aurorabuild.sh (line 46)
<https://reviews.apache.org/r/37092/#comment148631>
Context here on the purpose for the classpath prefix would be nice.
- Bill Farner
On Aug. 4, 2015, 8:58 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37092/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 8:58 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1425
> https://issues.apache.org/jira/browse/AURORA-1425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Modify the gradle build to optionally prefix CLASSPATH with a custom value when running installDist.
>
> This enables much greater iteration speed when working on the Aurora UI.
>
>
> Diffs
> -----
>
> build.gradle fa2e268047bfb4ad41f41e0c9e423ddb53ceb02d
> docs/developing-aurora-scheduler.md 17cfc183cfc5e9359df800e983d8bb45d70d4f9b
> examples/vagrant/aurorabuild.sh 8850e9382f4192873fe2d785e75a7d73403696d6
>
> Diff: https://reviews.apache.org/r/37092/diff/
>
>
> Testing
> -------
>
> Verified that I'm able to reload the UI in vagrant and have it pick up changes without restarting/rebuilding the scheduler.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 37092: Modify the gradle build to optionally prefix
CLASSPATH with a custom value when running installDist.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37092/#review94139
-----------------------------------------------------------
Ship it!
Master (2130f7e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 4, 2015, 9:59 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37092/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 9:59 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1425
> https://issues.apache.org/jira/browse/AURORA-1425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Modify the gradle build to optionally prefix CLASSPATH with a custom value when running installDist.
>
> This enables much greater iteration speed when working on the Aurora UI.
>
>
> Diffs
> -----
>
> build.gradle fa2e268047bfb4ad41f41e0c9e423ddb53ceb02d
> docs/developing-aurora-scheduler.md 17cfc183cfc5e9359df800e983d8bb45d70d4f9b
> examples/vagrant/aurorabuild.sh 8850e9382f4192873fe2d785e75a7d73403696d6
>
> Diff: https://reviews.apache.org/r/37092/diff/
>
>
> Testing
> -------
>
> Verified that I'm able to reload the UI in vagrant and have it pick up changes without restarting/rebuilding the scheduler.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 37092: Modify the gradle build to optionally prefix
CLASSPATH with a custom value when running installDist.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37092/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 9:59 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Add explanatory comment for CLASSPATH_PREFIX var.
Bugs: AURORA-1425
https://issues.apache.org/jira/browse/AURORA-1425
Repository: aurora
Description
-------
Modify the gradle build to optionally prefix CLASSPATH with a custom value when running installDist.
This enables much greater iteration speed when working on the Aurora UI.
Diffs (updated)
-----
build.gradle fa2e268047bfb4ad41f41e0c9e423ddb53ceb02d
docs/developing-aurora-scheduler.md 17cfc183cfc5e9359df800e983d8bb45d70d4f9b
examples/vagrant/aurorabuild.sh 8850e9382f4192873fe2d785e75a7d73403696d6
Diff: https://reviews.apache.org/r/37092/diff/
Testing
-------
Verified that I'm able to reload the UI in vagrant and have it pick up changes without restarting/rebuilding the scheduler.
Thanks,
Joshua Cohen
Re: Review Request 37092: Modify the gradle build to optionally prefix
CLASSPATH with a custom value when running installDist.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37092/#review94124
-----------------------------------------------------------
Ship it!
Master (7fdcfef) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 4, 2015, 8:58 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37092/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 8:58 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1425
> https://issues.apache.org/jira/browse/AURORA-1425
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Modify the gradle build to optionally prefix CLASSPATH with a custom value when running installDist.
>
> This enables much greater iteration speed when working on the Aurora UI.
>
>
> Diffs
> -----
>
> build.gradle fa2e268047bfb4ad41f41e0c9e423ddb53ceb02d
> docs/developing-aurora-scheduler.md 17cfc183cfc5e9359df800e983d8bb45d70d4f9b
> examples/vagrant/aurorabuild.sh 8850e9382f4192873fe2d785e75a7d73403696d6
>
> Diff: https://reviews.apache.org/r/37092/diff/
>
>
> Testing
> -------
>
> Verified that I'm able to reload the UI in vagrant and have it pick up changes without restarting/rebuilding the scheduler.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 37092: Modify the gradle build to optionally prefix
CLASSPATH with a custom value when running installDist.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37092/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 8:58 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Drop windows support to simplify the changes.
Also drop the printlns as I felt they were too noisy.
Bugs: AURORA-1425
https://issues.apache.org/jira/browse/AURORA-1425
Repository: aurora
Description
-------
Modify the gradle build to optionally prefix CLASSPATH with a custom value when running installDist.
This enables much greater iteration speed when working on the Aurora UI.
Diffs (updated)
-----
build.gradle fa2e268047bfb4ad41f41e0c9e423ddb53ceb02d
docs/developing-aurora-scheduler.md 17cfc183cfc5e9359df800e983d8bb45d70d4f9b
examples/vagrant/aurorabuild.sh 8850e9382f4192873fe2d785e75a7d73403696d6
Diff: https://reviews.apache.org/r/37092/diff/
Testing
-------
Verified that I'm able to reload the UI in vagrant and have it pick up changes without restarting/rebuilding the scheduler.
Thanks,
Joshua Cohen