You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smengcl (via GitHub)" <gi...@apache.org> on 2023/03/17 03:41:34 UTC
[GitHub] [ozone] smengcl commented on a diff in pull request #4377: HDDS-8058. Gracefully handle invalid S3 authorization header.
smengcl commented on code in PR #4377:
URL: https://github.com/apache/ozone/pull/4377#discussion_r1139666058
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/security/TestAWSV4AuthValidator.java:
##########
@@ -64,15 +67,74 @@ public static Collection<Object[]> data() {
"577efef23edd43b7e1a59",
"5d672d79c15b13162d9279b0855cfba" +
"6789a8edb4c82c400e06b5924a6f2b5d7",
- "wJalrXUtnFEMI/K7MDENG+bPxRfiCYEXAMPLEKEY"
+ "wJalrXUtnFEMI/K7MDENG+bPxRfiCYEXAMPLEKEY",
+ true
+ },
+ // Invalid Algorithm
Review Comment:
New test case: invalid signature
```suggestion
},
// Invalid signature
{
"AWS4-HMAC-SHA256\n" +
"20150830T123600Z\n" +
"20150830/us-east-1/iam/aws4_request\n" +
"f536975d06c0309214f805bb90ccff089219ecd68b2" +
"577efef23edd43b7e1a59",
"5d672d79c15b13162d9279b0855cfba" +
"6789a8edb4c82c400e06b5924a6f2b5d8",
"wJalrXUtnFEMI/K7MDENG+bPxRfiCYEXAMPLEKEY",
false
},
// Invalid Algorithm
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org