You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "LostArtist (via GitHub)" <gi...@apache.org> on 2023/10/18 15:09:58 UTC
[PR] cleanups: replaced File#delete with Files#delete [camel]
LostArtist opened a new pull request, #11762:
URL: https://github.com/apache/camel/pull/11762
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanups: replaced File#delete with Files#delete [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #11762:
URL: https://github.com/apache/camel/pull/11762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanups: replaced File#delete with Files#delete [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11762:
URL: https://github.com/apache/camel/pull/11762#issuecomment-1779080761
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanups: replaced File#delete with Files#delete [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #11762:
URL: https://github.com/apache/camel/pull/11762#issuecomment-1779079447
/component-test camel-file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanups: replaced File#delete with Files#delete [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11762:
URL: https://github.com/apache/camel/pull/11762#issuecomment-1768701657
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanups: replaced File#delete with Files#delete [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #11762:
URL: https://github.com/apache/camel/pull/11762#issuecomment-1779080399
/component-test camel-kafka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanups: replaced File#delete with Files#delete [camel]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #11762:
URL: https://github.com/apache/camel/pull/11762#issuecomment-1768743452
Are there any reasons why we should do that?
According to the Javadoc, the main interest in using `Files#delete` is for error reporting, to diagnose why a file cannot be deleted but in this PR you mostly don't care about the exception thrown so it is not really useful. Moreover, it causes [some known behavior changes](https://mail.openjdk.org/pipermail/core-libs-dev/2012-August/011314.html) and finally dealing with exceptions affects the performances so I tend to vote -1 for this change unless you have good reasons
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanups: replaced File#delete with Files#delete [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11762:
URL: https://github.com/apache/camel/pull/11762#issuecomment-1779079797
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org