You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/03/29 20:43:08 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #5742: DAP and LSP use a common Lookup.
sdedic opened a new pull request, #5742:
URL: https://github.com/apache/netbeans/pull/5742
When the user code is run/debug, DAP protocol is used for the launch request. Although the DAP server provided `OperationContext` for reporting progress, it did not provide any other LSP client's functions to the DAP-initiated processes within NBLS.
So when one runs (using codelen or command) a project or main class in a Maven project, with bad proxy settings, the Maven support wants to ask the user - and fails, since the DAP-initiated maven build has no access to `DialogDisplayer` that works through LSP connection with the LSP client to display confirmations.
This PR attempts to change DAP + LSP implementation so that the default Lookup for their request processing conains **both** DAP and LSP lookups (and of course request-specific items and the default Lookup as the last one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5742: DAP and LSP use a common Lookup.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5742:
URL: https://github.com/apache/netbeans/pull/5742#issuecomment-1489804852
Added a test to check that the default Lookup contents is present just once in commands, despite the proxies to proxies :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5742: DAP and LSP use a common Lookup.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5742:
URL: https://github.com/apache/netbeans/pull/5742#issuecomment-1490800156
I needed to change the way how the lookup extraction command hooks into the lookup. When I used MockLookup, it interfered with the default Lookup and prevented the module system from starting, so that Indexing support did not run its `@OnStart`, did not attach appropriate listeners on PathRegistry ... and finally it did not produce 'indexing finished' message at all - because it had no listeners hooked on the RepoUpdater.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #5742: DAP and LSP use a common Lookup.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #5742:
URL: https://github.com/apache/netbeans/pull/5742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists