You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/21 02:54:46 UTC
[GitHub] [shardingsphere] lanchengx opened a new pull request #14969: Fixed incomplete display of `count schema rules` when not configure
lanchengx opened a new pull request #14969:
URL: https://github.com/apache/shardingsphere/pull/14969
Changes proposed in this pull request:
- Fixed incomplete display of `count schema rules` when not configure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #14969: Fixed incomplete display of `count schema rules` when not configure
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #14969:
URL: https://github.com/apache/shardingsphere/pull/14969#discussion_r789316750
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rql/rule/SchemaRulesQueryResultSet.java
##########
@@ -85,13 +85,11 @@
public void init(final ShardingSphereMetaData metaData, final SQLStatement sqlStatement) {
Map<String, Collection<Object>> dataMap = new LinkedHashMap<>();
addSingleTableData(dataMap, metaData.getRuleMetaData().findRules(SingleTableRule.class));
- metaData.getRuleMetaData().getConfigurations().forEach(each -> {
- addShardingData(dataMap, each);
- addReadwriteSplittingData(dataMap, each);
- addDBDiscoveryData(dataMap, each);
- addEncryptData(dataMap, each);
- addShadowData(dataMap, each);
- });
+ if (hasAnyConfiguration(metaData)) {
Review comment:
hasRuleConfiguration may be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #14969: Fixed incomplete display of `count schema rules` when not configure
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged pull request #14969:
URL: https://github.com/apache/shardingsphere/pull/14969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org