You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2023/02/02 06:25:15 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request, #23923: Replace ExecutorDataMap with SeataXIDContext in SeataTransactionalSQLExecutionHook

strongduanmu opened a new pull request, #23923:
URL: https://github.com/apache/shardingsphere/pull/23923

   Ref #23884.
   
   Changes proposed in this pull request:
     - Replace ExecutorDataMap with SeataXIDContext in SeataTransactionalSQLExecutionHook
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #23923: Replace ExecutorDataMap with SeataXIDContext in SeataTransactionalSQLExecutionHook

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23923:
URL: https://github.com/apache/shardingsphere/pull/23923#issuecomment-1413238381

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23923](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84c833c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/87f4f45da64271132d2e5a1dfe3622ccf91cff81?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87f4f45) will **decrease** coverage by `0.03%`.
   > The diff coverage is `65.15%`.
   
   > :exclamation: Current head 84c833c differs from pull request most recent head 0ad9814. Consider uploading reports for the commit 0ad9814 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #23923      +/-   ##
   ============================================
   - Coverage     50.11%   50.09%   -0.03%     
     Complexity     1570     1570              
   ============================================
     Files          3243     3246       +3     
     Lines         53378    53433      +55     
     Branches       9796     9808      +12     
   ============================================
   + Hits          26751    26765      +14     
   - Misses        24274    24309      +35     
   - Partials       2353     2359       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ere/agent/plugin/tracing/core/RootSpanContext.java](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL2NvcmUvUm9vdFNwYW5Db250ZXh0LmphdmE=) | `0.00% <ø> (ø)` | |
   | [...nfra/util/expr/EspressoInlineExpressionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leHByL0VzcHJlc3NvSW5saW5lRXhwcmVzc2lvblBhcnNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...sphere/infra/util/expr/InlineExpressionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leHByL0lubGluZUV4cHJlc3Npb25QYXJzZXIuamF2YQ==) | `43.47% <40.90%> (-50.97%)` | :arrow_down: |
   | [...e/seata/at/SeataTransactionalSQLExecutionHook.java](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL3R5cGUvYmFzZS9zZWF0YS1hdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24vYmFzZS9zZWF0YS9hdC9TZWF0YVRyYW5zYWN0aW9uYWxTUUxFeGVjdXRpb25Ib29rLmphdmE=) | `78.57% <75.00%> (ø)` | |
   | [...til/groovy/expr/HotspotInlineExpressionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvdXRpbC1ncm9vdnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3V0aWwvZ3Jvb3Z5L2V4cHIvSG90c3BvdElubGluZUV4cHJlc3Npb25QYXJzZXIuamF2YQ==) | `94.44% <94.44%> (ø)` | |
   | [...ecute/engine/driver/jdbc/JDBCExecutorCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL2VuZ2luZS9kcml2ZXIvamRiYy9KREJDRXhlY3V0b3JDYWxsYmFjay5qYXZh) | `88.57% <100.00%> (ø)` | |
   | [...e/infra/executor/sql/hook/SPISQLExecutionHook.java](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9ob29rL1NQSVNRTEV4ZWN1dGlvbkhvb2suamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...ere/transaction/base/seata/at/SeataXIDContext.java](https://codecov.io/gh/apache/shardingsphere/pull/23923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL3R5cGUvYmFzZS9zZWF0YS1hdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24vYmFzZS9zZWF0YS9hdC9TZWF0YVhJRENvbnRleHQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tristaZero merged pull request #23923: Replace ExecutorDataMap with SeataXIDContext in SeataTransactionalSQLExecutionHook

Posted by "tristaZero (via GitHub)" <gi...@apache.org>.
tristaZero merged PR #23923:
URL: https://github.com/apache/shardingsphere/pull/23923


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org