You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/26 14:54:05 UTC

[GitHub] [apisix] Yangzcy423911 opened a new issue, #3230: bug: when modify config file apisix shoud check config file

Yangzcy423911 opened a new issue, #3230:
URL: https://github.com/apache/apisix/issues/3230

   ### Issue description
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): apisix 2.1
   * OS: (cmd: `uname -a`) centos 7.6
   * OpenResty / Nginx version: (cmd: `nginx -V` or `openresty -V`)
   
   ### Minimal test code / Steps to reproduce the issue
   
   1.  when apisix running and modify config file ,when config file error apisix restart fail  ,service down
   2. apisix should check modify config file , example nginx -t , avoid error 
   3.
   
   ### What's the actual result? (including assertion message & call stack if applicable)
   
   ### What's the expected result?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] spacewander closed issue #3230: bug: when modify config file apisix shoud check config file

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #3230: bug:  when modify  config file apisix shoud check config file 
URL: https://github.com/apache/apisix/issues/3230


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] tokers commented on issue #3230: bug: when modify config file apisix shoud check config file

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #3230:
URL: https://github.com/apache/apisix/issues/3230#issuecomment-1139174443

   > > i mean, i didn't know it exists:
   > 
   > maybe we need to add `test` to `apisix help`? cc @spacewander @nic-chen
   
   It's usefult. Just like `nginx -t`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] nic-chen commented on issue #3230: bug: when modify config file apisix shoud check config file

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #3230:
URL: https://github.com/apache/apisix/issues/3230#issuecomment-1139180735

   > > i mean, i didn't know it exists:
   > 
   > maybe we need to add `test` to `apisix help`? cc @spacewander @nic-chen
   
   +1 
   add `apisix test` to `apisix help`, people could know this command quickly.
   
   @apit  welcome to submit a PR to make it done. : )
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] spacewander commented on issue #3230: bug: when modify config file apisix shoud check config file

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3230:
URL: https://github.com/apache/apisix/issues/3230#issuecomment-1139188049

   Let's move the discussion to https://github.com/apache/apisix/issues/7148 as this validation is already done. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] tzssangglass commented on issue #3230: bug: when modify config file apisix shoud check config file

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #3230:
URL: https://github.com/apache/apisix/issues/3230#issuecomment-1138665797

   > i mean, i didn't know it exists:
   
   maybe we need to add `test` to `apisix help`? cc @spacewander @nic-chen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] apit commented on issue #3230: bug: when modify config file apisix shoud check config file

Posted by GitBox <gi...@apache.org>.
apit commented on issue #3230:
URL: https://github.com/apache/apisix/issues/3230#issuecomment-1138063739

   shouldn't `test` usage added to `apisix help`? as of 2.12.1 it's not there


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] tzssangglass commented on issue #3230: bug: when modify config file apisix shoud check config file

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #3230:
URL: https://github.com/apache/apisix/issues/3230#issuecomment-1138182236

   > shouldn't `test` usage added to `apisix help`? as of 2.12.1 it's not there
   
   `test` usage has been released as of 2.11.0. If this is not your verification result, you can submit a new issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] apit commented on issue #3230: bug: when modify config file apisix shoud check config file

Posted by GitBox <gi...@apache.org>.
apit commented on issue #3230:
URL: https://github.com/apache/apisix/issues/3230#issuecomment-1138337058

   i mean, i didn't know it exists:
   ```
   /opt/apisix> docker-compose exec apisix apisix help
   /usr/local/openresty/luajit/bin/luajit ./apisix/cli/apisix.lua help
   Usage: apisix [action] <argument>
   
   help:       show this message, then exit
   init:       initialize the local nginx.conf
   init_etcd:  initialize the data of etcd
   start:      start the apisix server
   stop:       stop the apisix server
   quit:       stop the apisix server gracefully
   restart:    restart the apisix server
   reload:     reload the apisix server
   version:    print the version of apisix
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org