You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "alberto-bogi (via GitHub)" <gi...@apache.org> on 2025/06/30 07:53:17 UTC
[PR] [SYNCOPE-1890] Property relative to max retry attempts for Syncope authentication module configurable on WA [syncope]
alberto-bogi opened a new pull request, #1119:
URL: https://github.com/apache/syncope/pull/1119
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1890] Setting maxRetryAttempts for Syncope auth module [syncope]
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on PR #1119:
URL: https://github.com/apache/syncope/pull/1119#issuecomment-3023048656
Thank you @alberto-bogi !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1890] Setting maxRetryAttempts for Syncope auth module [syncope]
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso merged PR #1119:
URL: https://github.com/apache/syncope/pull/1119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1890] Setting maxRetryAttempts for Syncope auth module [syncope]
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on code in PR #1119:
URL: https://github.com/apache/syncope/pull/1119#discussion_r2174454970
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SyncopeAuthModuleConf.java:
##########
@@ -55,6 +57,10 @@ public void setCredentialCriteria(final String credentialCriteria) {
this.credentialCriteria = credentialCriteria;
}
+ public int getMaxRetryAttempts() { return maxRetryAttempts; }
+
+ public void setMaxRetryAttempts(int maxRetryAttempts) { this.maxRetryAttempts = maxRetryAttempts; }
Review Comment:
this is not going to pass checkstyle: ensure to run the build locally before submitting
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SyncopeAuthModuleConf.java:
##########
@@ -39,6 +39,8 @@ public class SyncopeAuthModuleConf implements AuthModuleConf {
*/
private String credentialCriteria;
+ private int maxRetryAttempts = 1;
Review Comment:
add `@Min(1)` to this property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1890] Setting maxRetryAttempts for Syncope auth module [syncope]
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on PR #1119:
URL: https://github.com/apache/syncope/pull/1119#issuecomment-3018170198
Cfr https://github.com/apereo/cas/pull/7145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org