You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/03/17 17:36:59 UTC

Review Request 32162: Improve logging of RMF

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32162/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-10109
    https://issues.apache.org/jira/browse/AMBARI-10109


Repository: ambari


Description
-------

This includes:

  * add outputting of return values (retcode and out) of shell calls.
  * remove redundant u"" prefix from all of the logged resources
  * remove redundant messages of hdp-select after every task sucess and after every task failure.


Diffs
-----

  ambari-agent/src/test/python/resource_management/TestDirectoryResource.py f42de93 
  ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py a368e5d 
  ambari-agent/src/test/python/resource_management/TestFileResource.py f60fc12 
  ambari-agent/src/test/python/resource_management/TestLinkResource.py 2d5194c 
  ambari-agent/src/test/python/resource_management/TestMonitorWebserverResource.py 2125e72 
  ambari-agent/src/test/python/resource_management/TestScript.py da9aa0e 
  ambari-common/src/main/python/resource_management/core/base.py cc5f111 
  ambari-common/src/main/python/resource_management/core/shell.py cfa87f6 
  ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py 138b97f 

Diff: https://reviews.apache.org/r/32162/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 32162: Improve logging of RMF

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32162/#review76742
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On March 17, 2015, 4:36 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32162/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 4:36 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-10109
>     https://issues.apache.org/jira/browse/AMBARI-10109
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This includes:
> 
>   * add outputting of return values (retcode and out) of shell calls.
>   * remove redundant u"" prefix from all of the logged resources
>   * remove redundant messages of hdp-select after every task sucess and after every task failure.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestDirectoryResource.py f42de93 
>   ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py a368e5d 
>   ambari-agent/src/test/python/resource_management/TestFileResource.py f60fc12 
>   ambari-agent/src/test/python/resource_management/TestLinkResource.py 2d5194c 
>   ambari-agent/src/test/python/resource_management/TestMonitorWebserverResource.py 2125e72 
>   ambari-agent/src/test/python/resource_management/TestScript.py da9aa0e 
>   ambari-common/src/main/python/resource_management/core/base.py cc5f111 
>   ambari-common/src/main/python/resource_management/core/shell.py cfa87f6 
>   ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py 138b97f 
> 
> Diff: https://reviews.apache.org/r/32162/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>