You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/26 22:08:08 UTC
Review Request 65358: Removed unnecesssary validations from
`Master::receive()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65358/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description
-------
`validation::scheduler::call::validate(call)` is called at the top of
`master::receive()`, so it doesn't need to validate the calls again.
Diffs
-----
src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
Diff: https://reviews.apache.org/r/65358/diff/1/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 65358: Removed unnecesssary validations from
`Master::receive()`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65358/#review196471
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Jan. 26, 2018, 10:08 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65358/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 10:08 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `validation::scheduler::call::validate(call)` is called at the top of
> `master::receive()`, so it doesn't need to validate the calls again.
>
>
> Diffs
> -----
>
> src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
>
>
> Diff: https://reviews.apache.org/r/65358/diff/1/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>