You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Cong Wang <xi...@gmail.com> on 2016/04/02 00:06:06 UTC

Review Request 45607: Moved HTB out of containers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45607/
-----------------------------------------------------------

Review request for mesos, Ian Downes and Jie Yu.


Bugs: mesos-4749
    https://issues.apache.org/jira/browse/mesos-4749


Repository: mesos


Description
-------

Move HTB out of containers so that containers could borrow bandwidth when idle.


Diffs
-----

  src/linux/routing/queueing/fq_codel.hpp 6fcd9a21e821da476e9c16f50ed781424338022a 
  src/linux/routing/queueing/fq_codel.cpp 26860d1552839b47be2b4cbdc575c0d20e6fcdc5 
  src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 0fe2f486eb733acf738c1c61fc44f820d7401afc 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 323c84a3d960a196d8ba87f753814e9d43a07957 

Diff: https://reviews.apache.org/r/45607/diff/


Testing
-------

Manual test with --egress_unique_flow_per_container and/or --egress_rate_limit_per_container


Thanks,

Cong Wang

Re: Review Request 45607: Move HTB qdisc out of containers.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45607/#review126663
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45605, 45606, 45607]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 1, 2016, 11:05 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45607/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 11:05 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: mesos-4749
>     https://issues.apache.org/jira/browse/mesos-4749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move HTB qdisc out of containers.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/queueing/fq_codel.hpp 6fcd9a21e821da476e9c16f50ed781424338022a 
>   src/linux/routing/queueing/fq_codel.cpp 26860d1552839b47be2b4cbdc575c0d20e6fcdc5 
>   src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 0fe2f486eb733acf738c1c61fc44f820d7401afc 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 323c84a3d960a196d8ba87f753814e9d43a07957 
> 
> Diff: https://reviews.apache.org/r/45607/diff/
> 
> 
> Testing
> -------
> 
> Manual test with --egress_unique_flow_per_container and/or --egress_rate_limit_per_container
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 45607: Move HTB qdisc out of containers.

Posted by Cong Wang <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45607/
-----------------------------------------------------------

(Updated April 1, 2016, 11:05 p.m.)


Review request for mesos, Ian Downes and Jie Yu.


Changes
-------

Updated counters


Summary (updated)
-----------------

Move HTB qdisc out of containers.


Bugs: mesos-4749
    https://issues.apache.org/jira/browse/mesos-4749


Repository: mesos


Description (updated)
-------

Move HTB qdisc out of containers.


Diffs (updated)
-----

  src/linux/routing/queueing/fq_codel.hpp 6fcd9a21e821da476e9c16f50ed781424338022a 
  src/linux/routing/queueing/fq_codel.cpp 26860d1552839b47be2b4cbdc575c0d20e6fcdc5 
  src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 0fe2f486eb733acf738c1c61fc44f820d7401afc 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 323c84a3d960a196d8ba87f753814e9d43a07957 

Diff: https://reviews.apache.org/r/45607/diff/


Testing
-------

Manual test with --egress_unique_flow_per_container and/or --egress_rate_limit_per_container


Thanks,

Cong Wang