You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/17 11:22:30 UTC

[GitHub] [arrow] alamb commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0

alamb commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761777508


   > Since rust crate version numbers without leading '^' sometimes leads to confusions, how about prepend the versions changed in this PR with '^' to make it more clear?
   
   @mqy  -- I think it is common in rust projects (especially library crates like Arrow) to allow some flexibility in their dependencies and thus not prefix with `^`. 
   
   Cargo claims to implement [semve](https://semver.org/) -- which I think means  in theory crate publishers should take care and ensure that "non major version upgrades" (aka 1.2.1 --> 1.2.2, or 1.2.1 --> 1.3.0) don't contain breaking changes. If you use the `^` prefix we would prevent crates / projects that depend of Arrow from using anything other than the exact version specified. 
   
   As you saw, the parquet-format crate didn't follow the semver versioning convention thus breaking our CI :(


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org