You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2015/03/18 21:37:38 UTC

[jira] [Commented] (CALCITE-629) Can't use extended version of CalcitePrepareImpl with JDBC Driver

    [ https://issues.apache.org/jira/browse/CALCITE-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367840#comment-14367840 ] 

Julian Hyde commented on CALCITE-629:
-------------------------------------

Please describe your use case. I am loathe to open up internals without a good reason. Otherwise you will complain when CalcitePrepareImpl changes in version 1.x.

> Can't use extended version of CalcitePrepareImpl with JDBC Driver
> -----------------------------------------------------------------
>
>                 Key: CALCITE-629
>                 URL: https://issues.apache.org/jira/browse/CALCITE-629
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.0.0-incubating
>            Reporter: Eugene Zimichev
>            Assignee: Julian Hyde
>
> Constructor of CalciteConnectionImpl directly uses field Driver#prepareFactory, although Driver class provides protected method that can redefine it.
> Because of field hiding user can't register a custom extension of CalciteConnectionImpl.
> Proposed fix - use createPrepareFactory method instead of field access.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)