You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/08 20:38:04 UTC
[GitHub] [spark] robert3005 opened a new pull request #29980: [SPARK-21195][CORE] MetricSystem should pick up dynamically registered metrics in sources
robert3005 opened a new pull request #29980:
URL: https://github.com/apache/spark/pull/29980
### What changes were proposed in this pull request?
MetricSystem picks up new metrics from sources that are added throughout execution. If you do measurements via dynamic proxies you might not want to redeclare all metrics that the proxies will create and you'd prefer them to get populated as they're being produced. Right now all sources are processed only onceat startup and metrics are picked up only if they have been registered statically at compile time. Behaviour I am proposing lets you not have to declare metrics in two places.
### Why are the changes needed?
Currently there's no way to access MetricRegistry that MetricsSystem uses to hold its state and as such it's not possible to reprocess a source. MetricsSystem throws if any metric had already been registered previously.
n.b. the MetricRegistry is added as a constructor argument to make testing easier but could as well be accessed via reflection as a private variable.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29980: [SPARK-21195][CORE] MetricSystem should pick up dynamically registered metrics in sources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29980:
URL: https://github.com/apache/spark/pull/29980#issuecomment-705810319
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29980: [SPARK-21195][CORE] MetricSystem should pick up dynamically registered metrics in sources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29980:
URL: https://github.com/apache/spark/pull/29980#issuecomment-705813313
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29980: [SPARK-21195][CORE] MetricSystem should pick up dynamically registered metrics in sources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29980:
URL: https://github.com/apache/spark/pull/29980#issuecomment-705810319
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29980: [SPARK-21195][CORE] MetricSystem should pick up dynamically registered metrics in sources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29980:
URL: https://github.com/apache/spark/pull/29980#issuecomment-705810319
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #29980: [SPARK-21195][CORE] MetricSystem should pick up dynamically registered metrics in sources
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #29980:
URL: https://github.com/apache/spark/pull/29980#issuecomment-761711375
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #29980: [SPARK-21195][CORE] MetricSystem should pick up dynamically registered metrics in sources
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #29980:
URL: https://github.com/apache/spark/pull/29980
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29980: [SPARK-21195][CORE] MetricSystem should pick up dynamically registered metrics in sources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29980:
URL: https://github.com/apache/spark/pull/29980#issuecomment-705810319
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org