You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Radhika PC <ra...@citrix.com> on 2013/02/06 07:26:56 UTC
Re: Review Request: Support for Egress Firewall Rule
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8813/
-----------------------------------------------------------
(Updated Feb. 6, 2013, 6:26 a.m.)
Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
Changes
-------
this patch addresses the issue reported in the review
Description
-------
Documentation on egress firewall rule support
Diffs (updated)
-----
docs/en-US/add-ingress-egress-rules.xml 2490cec
docs/en-US/egress-firewall-rule.xml PRE-CREATION
docs/en-US/firewall-rules.xml 01d072b
docs/en-US/images/egress-firewall-rule.png PRE-CREATION
docs/en-US/ip-forwarding-firewalling.xml c154b07
Diff: https://reviews.apache.org/r/8813/diff/
Testing
-------
Publican builds cleanly. Patch cleanly applies.
Thanks,
Radhika PC
Re: Review Request: Support for Egress Firewall Rule
Posted by Radhika PC <ra...@citrix.com>.
> On Feb. 14, 2013, 2:22 p.m., David Nalley wrote:
> > So this applies cleanly on 4.1 and master
> >
> > However, when I try and build the admin guide I get the following validation error (it passes the test, but won't render a doc)
> > Validation failed:
> > creating-network-offerings.xml:215: validity error : IDREF attribute linkend references an unknown ID "firewall-rules"
> >
> >
I had fixed this IDREF issue in my last patch for persistent network which has changes to creating-network-offering.xml!!!
creating-network-offering.xml is a tricky file. Last patch failed on both master and 4.1 because of the same file but different reasons. And I realized that latest changes on the same file is submitted with the patch on persistent network.
Now, I will create another patch based on the latest changes gone with persistent network.
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8813/#review16578
-----------------------------------------------------------
On Feb. 6, 2013, 6:26 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8813/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 6:26 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
>
>
> Description
> -------
>
> Documentation on egress firewall rule support
>
>
> Diffs
> -----
>
> docs/en-US/add-ingress-egress-rules.xml 2490cec
> docs/en-US/egress-firewall-rule.xml PRE-CREATION
> docs/en-US/firewall-rules.xml 01d072b
> docs/en-US/images/egress-firewall-rule.png PRE-CREATION
> docs/en-US/ip-forwarding-firewalling.xml c154b07
>
> Diff: https://reviews.apache.org/r/8813/diff/
>
>
> Testing
> -------
>
> Publican builds cleanly. Patch cleanly applies.
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Support for Egress Firewall Rule
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8813/#review16578
-----------------------------------------------------------
So this applies cleanly on 4.1 and master
However, when I try and build the admin guide I get the following validation error (it passes the test, but won't render a doc)
Validation failed:
creating-network-offerings.xml:215: validity error : IDREF attribute linkend references an unknown ID "firewall-rules"
- David Nalley
On Feb. 6, 2013, 6:26 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8813/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 6:26 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
>
>
> Description
> -------
>
> Documentation on egress firewall rule support
>
>
> Diffs
> -----
>
> docs/en-US/add-ingress-egress-rules.xml 2490cec
> docs/en-US/egress-firewall-rule.xml PRE-CREATION
> docs/en-US/firewall-rules.xml 01d072b
> docs/en-US/images/egress-firewall-rule.png PRE-CREATION
> docs/en-US/ip-forwarding-firewalling.xml c154b07
>
> Diff: https://reviews.apache.org/r/8813/diff/
>
>
> Testing
> -------
>
> Publican builds cleanly. Patch cleanly applies.
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Support for Egress Firewall Rule
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8813/#review16646
-----------------------------------------------------------
Patch applied cleanly to both master and 4.1 . Merged to both the branches -
master - Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/2beb66fd
4.1 - Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/d11505f4
Please mark the review request as Submitted .
Thanks !
- Pranav Saxena
On Feb. 14, 2013, 4:41 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8813/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 4:41 p.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
>
>
> Description
> -------
>
> Documentation on egress firewall rule support
>
>
> Diffs
> -----
>
> docs/en-US/creating-network-offerings.xml df39242
> docs/en-US/egress-firewall-rule.xml PRE-CREATION
> docs/en-US/firewall-rules.xml 01d072b
> docs/en-US/images/egress-firewall-rule.png PRE-CREATION
> docs/en-US/ip-forwarding-firewalling.xml c154b07
>
> Diff: https://reviews.apache.org/r/8813/diff/
>
>
> Testing
> -------
>
> Publican builds cleanly. Patch cleanly applies.
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Support for Egress Firewall Rule
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8813/
-----------------------------------------------------------
(Updated Feb. 14, 2013, 4:41 p.m.)
Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
Changes
-------
Fixes the IDREF issues. Please submit the patch to the master. I am yet to submit another patch for 4.1 as both are diverged.
Description
-------
Documentation on egress firewall rule support
Diffs
-----
docs/en-US/creating-network-offerings.xml df39242
docs/en-US/egress-firewall-rule.xml PRE-CREATION
docs/en-US/firewall-rules.xml 01d072b
docs/en-US/images/egress-firewall-rule.png PRE-CREATION
docs/en-US/ip-forwarding-firewalling.xml c154b07
Diff: https://reviews.apache.org/r/8813/diff/
Testing
-------
Publican builds cleanly. Patch cleanly applies.
Thanks,
Radhika PC
Re: Review Request: Support for Egress Firewall Rule
Posted by Radhika PC <ra...@citrix.com>.
> On Feb. 14, 2013, 2:59 p.m., Jayapal Reddy wrote:
> > docs/en-US/egress-firewall-rule.xml, line 40
> > <https://reviews.apache.org/r/8813/diff/2/?file=256012#file256012line40>
> >
> > TCP, UDP, ICMP and ALL protocol.
> > Please add the 'ALL' also.
> > Protocol 'ALL' is allow all the traffic.
ALL ~ or all the three
already mentioned.
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8813/#review16581
-----------------------------------------------------------
On Feb. 14, 2013, 4:41 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8813/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 4:41 p.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
>
>
> Description
> -------
>
> Documentation on egress firewall rule support
>
>
> Diffs
> -----
>
> docs/en-US/creating-network-offerings.xml df39242
> docs/en-US/egress-firewall-rule.xml PRE-CREATION
> docs/en-US/firewall-rules.xml 01d072b
> docs/en-US/images/egress-firewall-rule.png PRE-CREATION
> docs/en-US/ip-forwarding-firewalling.xml c154b07
>
> Diff: https://reviews.apache.org/r/8813/diff/
>
>
> Testing
> -------
>
> Publican builds cleanly. Patch cleanly applies.
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Support for Egress Firewall Rule
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8813/#review16581
-----------------------------------------------------------
docs/en-US/egress-firewall-rule.xml
<https://reviews.apache.org/r/8813/#comment35168>
TCP, UDP, ICMP and ALL protocol.
Please add the 'ALL' also.
Protocol 'ALL' is allow all the traffic.
- Jayapal Reddy
On Feb. 6, 2013, 6:26 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8813/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 6:26 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
>
>
> Description
> -------
>
> Documentation on egress firewall rule support
>
>
> Diffs
> -----
>
> docs/en-US/add-ingress-egress-rules.xml 2490cec
> docs/en-US/egress-firewall-rule.xml PRE-CREATION
> docs/en-US/firewall-rules.xml 01d072b
> docs/en-US/images/egress-firewall-rule.png PRE-CREATION
> docs/en-US/ip-forwarding-firewalling.xml c154b07
>
> Diff: https://reviews.apache.org/r/8813/diff/
>
>
> Testing
> -------
>
> Publican builds cleanly. Patch cleanly applies.
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Support for Egress Firewall Rule
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8813/
-----------------------------------------------------------
(Updated Feb. 14, 2013, 4:41 p.m.)
Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
Changes
-------
Fixes the IDREF issues. Please submit the patch to the master. I am yet to submit another patch for 4.1 as both are diverged.
Description
-------
Documentation on egress firewall rule support
Diffs (updated)
-----
docs/en-US/creating-network-offerings.xml df39242
docs/en-US/egress-firewall-rule.xml PRE-CREATION
docs/en-US/firewall-rules.xml 01d072b
docs/en-US/images/egress-firewall-rule.png PRE-CREATION
docs/en-US/ip-forwarding-firewalling.xml c154b07
Diff: https://reviews.apache.org/r/8813/diff/
Testing
-------
Publican builds cleanly. Patch cleanly applies.
Thanks,
Radhika PC