You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2014/08/28 09:44:19 UTC
[GitHub] couchdb-fauxton pull request: Make velocity dependancy of velocity...
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/46
Make velocity dependancy of velocity.ui
This will fix the velocity issue that causes the api bar not to work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton fix-velocity-loading
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit a595e2798a3e91bc27f8a407f6d88eb289a401e0
Author: Garren Smith <ga...@gmail.com>
Date: 2014-08-28T07:43:30Z
Make velocity dependancy of velocity.ui
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Make velocity dependancy of velocity...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/46#issuecomment-53696594
@kxepal Could you try again. I've tweaked the dependancy management some more. Also I'm downloading an ubuntu vm right now so I can do better testing myself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Make velocity dependancy of velocity...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/46#issuecomment-53711402
Hooray! No more velocity errors! API button works as it have to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Make velocity dependancy of velocity...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/46#issuecomment-53710935
@kxepal could you test again. I've had to do a somewhat hacky fix but the only way around this stupid error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Make velocity dependancy of velocity...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/46#issuecomment-53711342
oh, that fix looks untrivial
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Make velocity dependancy of velocity...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/46#issuecomment-53717118
Great! Thanks for testing. I've merged it. Sorry I forgot to squish so slightly messy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Make velocity dependancy of velocity...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/46#issuecomment-53690121
Suddenly, doesn't works for me and also it doesn't solves the related warning in console:
```
12:57:06.031 Use of getUserData() or setUserData() is deprecated. Use WeakMap or element.dataset instead. requestNotifier.js:63
12:57:06.570 mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create require.js:11
12:57:06.579 "Velocity UI Pack: Velocity must be loaded first. Aborting." require.js:26
12:57:06.706 window.controllers is deprecated. Do not use it for UA detection. require.js:16
12:57:06.894 Use of getPreventDefault() is deprecated. Use defaultPrevented instead. flashblock.xml:119
12:57:10.244 "Velocity: First argument (transition.slideDownIn) was not a property map, a known action, or a registered sequence. Aborting." require.js:15
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Make velocity dependancy of velocity...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/46#issuecomment-53752726
There should land proper AMD support soon: https://github.com/julianshapiro/velocity/pull/264
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Make velocity dependancy of velocity...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Make velocity dependancy of velocity...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/46#issuecomment-53699397
@garrensmith something really had changed, but still doesn't works:
```
14:03:00.395 TypeError: this.$(...).velocity is not a function require.js:26
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---