You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/05 12:18:42 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #11087: MINOR: [R] Fix nightly R failures
nealrichardson opened a new pull request #11087:
URL: https://github.com/apache/arrow/pull/11087
From ARROW-13874 and ARROW-13740
cc @thisisnic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #11087: MINOR: [R] Fix nightly R failures
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#discussion_r702736047
##########
File path: r/tests/testthat/test-compute-no-bindings.R
##########
@@ -15,6 +15,8 @@
# specific language governing permissions and limitations
# under the License.
+skip_if_not_available("utf8proc")
+
test_that("non-bound compute kernels using TrimOptions", {
Review comment:
```suggestion
test_that("non-bound compute kernels using TrimOptions", {
skip_if_not_available("utf8proc")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11087: MINOR: [R] Fix nightly R failures
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#issuecomment-913144417
Revision: f33b2c19d2ffad97493a92de597ff7f1aad2cb63
Submitted crossbow builds: [ursacomputing/crossbow @ actions-819](https://github.com/ursacomputing/crossbow/branches/all?query=actions-819)
|Task|Status|
|----|------|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-819-azure-test-r-minimal-build)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-819-github-test-r-versions)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11087: MINOR: [R] Fix nightly R failures
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#issuecomment-913169885
Revision: e719e710d532357735fe80cca5fae951d13f5e6d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-821](https://github.com/ursacomputing/crossbow/branches/all?query=actions-821)
|Task|Status|
|----|------|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-821-github-test-r-versions)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #11087: MINOR: [R] Fix nightly R failures
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#discussion_r702736047
##########
File path: r/tests/testthat/test-compute-no-bindings.R
##########
@@ -15,6 +15,8 @@
# specific language governing permissions and limitations
# under the License.
+skip_if_not_available("utf8proc")
+
test_that("non-bound compute kernels using TrimOptions", {
Review comment:
Should we put this inside the test, so that when we add other tests which don't require `utf8proc` to this file, they still run?
```suggestion
test_that("non-bound compute kernels using TrimOptions", {
skip_if_not_available("utf8proc")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #11087: MINOR: [R] Fix nightly R failures
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#discussion_r702736047
##########
File path: r/tests/testthat/test-compute-no-bindings.R
##########
@@ -15,6 +15,8 @@
# specific language governing permissions and limitations
# under the License.
+skip_if_not_available("utf8proc")
+
test_that("non-bound compute kernels using TrimOptions", {
Review comment:
Should we put this inside the test, so that when we add other tests which don't require utf8proc, they still run?
```suggestion
test_that("non-bound compute kernels using TrimOptions", {
skip_if_not_available("utf8proc")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #11087: MINOR: [R] Fix nightly R failures
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#discussion_r702736047
##########
File path: r/tests/testthat/test-compute-no-bindings.R
##########
@@ -15,6 +15,8 @@
# specific language governing permissions and limitations
# under the License.
+skip_if_not_available("utf8proc")
+
test_that("non-bound compute kernels using TrimOptions", {
Review comment:
How about we put this inside the test, so that when we add other tests which don't require `utf8proc` to this file, they still run?
```suggestion
test_that("non-bound compute kernels using TrimOptions", {
skip_if_not_available("utf8proc")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #11087: ARROW-13912: [R] TrimOptions implementation breaks test-r-minimal-build due to dependencies
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #11087:
URL: https://github.com/apache/arrow/pull/11087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11087: MINOR: [R] Fix nightly R failures
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#issuecomment-913165111
Revision: 6b1e2521eb4789c131edf2f78adce54672c3e02e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-820](https://github.com/ursacomputing/crossbow/branches/all?query=actions-820)
|Task|Status|
|----|------|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-820-github-test-r-versions)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #11087: MINOR: [R] Fix nightly R failures
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#issuecomment-913144244
@github-actions crossbow submit test-r-minimal-build test-r-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #11087: MINOR: [R] Fix nightly R failures
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#issuecomment-913164971
@github-actions crossbow submit test-r-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11087: ARROW-13912: [R] TrimOptions implementation breaks test-r-minimal-build due to dependencies
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#issuecomment-913619324
https://issues.apache.org/jira/browse/ARROW-13912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #11087: MINOR: [R] Fix nightly R failures
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #11087:
URL: https://github.com/apache/arrow/pull/11087#issuecomment-913169728
@github-actions crossbow submit test-r-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org