You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/08/08 14:46:10 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #24916: fix: Tooltip of area chart shows undefined total
michael-s-molina opened a new pull request, #24916:
URL: https://github.com/apache/superset/pull/24916
### SUMMARY
Fixes a bug where the tooltip of the area chart displays `undefined` totals.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1129" alt="Screenshot 2023-08-08 at 11 38 30" src="https://github.com/apache/superset/assets/70410625/a820f01e-5e8f-4bb4-a77c-5ccaa35fe1b4">
<img width="1143" alt="Screenshot 2023-08-08 at 11 37 16" src="https://github.com/apache/superset/assets/70410625/c1d95a97-5a13-4c9a-80ca-831a064edb23">
### TESTING INSTRUCTIONS
Make sure the total are correctly calculated.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #24916: fix: Tooltip of area chart shows undefined total
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #24916:
URL: https://github.com/apache/superset/pull/24916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24916: fix: Tooltip of area chart shows undefined total
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24916:
URL: https://github.com/apache/superset/pull/24916#issuecomment-1669895500
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24916](https://app.codecov.io/gh/apache/superset/pull/24916?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (35faf20) into [master](https://app.codecov.io/gh/apache/superset/commit/85a7d5cb3ebe833cfc2980f0846f15bb7ce1dd01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (85a7d5c) will **decrease** coverage by `0.01%`.
> Report is 1 commits behind head on master.
> The diff coverage is `0.00%`.
> :exclamation: Current head 35faf20 differs from pull request most recent head 34308fe. Consider uploading reports for the commit 34308fe to get more accurate results
```diff
@@ Coverage Diff @@
## master #24916 +/- ##
==========================================
- Coverage 69.00% 68.99% -0.01%
==========================================
Files 1906 1906
Lines 74134 74135 +1
Branches 8208 8208
==========================================
Hits 51153 51153
- Misses 20858 20859 +1
Partials 2123 2123
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.83% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/superset/pull/24916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...tend/plugins/legacy-preset-chart-nvd3/src/utils.js](https://app.codecov.io/gh/apache/superset/pull/24916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL3V0aWxzLmpz) | `15.82% <0.00%> (-0.11%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org