[GitHub] [hadoop] yellowflash commented on a change in pull request #3338: HADOOP-17870 Make Http Filesystem allow non-absolute uri based paths.

[GitBox <gi...@apache.org>]

yellowflash commented on a change in pull request #3338:
URL: https://github.com/apache/hadoop/pull/3338#discussion_r696628021



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/http/AbstractHttpFileSystem.java
##########
@@ -60,7 +60,7 @@ public URI getUri() {
 
   @Override
   public FSDataInputStream open(Path path, int bufferSize) throws IOException {
-    URLConnection conn = path.toUri().toURL().openConnection();
+    URLConnection conn = path.makeQualified(this.getUri(), null).toUri().toURL().openConnection();

Review comment:
       Yes you are correct. Fixed it by using `makeQualified(Path path)` which is overridden by the Filesystem the way you mentioned.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org