You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@hbase.apache.org by "Michael.Calvin" <77...@qq.com> on 2014/07/16 10:26:03 UTC
re： What's the exact procedure of making a custom filter work?
No. There isn't any abstract methods. And if there is any I wouldn't be able to compile it.
------------------
Michael.Calvin.Shi
Ted Yu <yu...@...> writes:
>
> FilterBase is abstract. Have you implemented the abstract methods ?
>
Re: RE： RE： re： What's the exact procedure of making a custom filter work?
Posted by Ted Yu <yu...@gmail.com>.
Here is the googledoc on API Incompatibilities from 0.94 -> 0.95.2:
https://docs.google.com/a/cloudera.com/document/d/14nqQXlIvgJOxGFTfhSoquYzjW8Yx-v9TqTBqRjiB7g0
<https://docs.google.com/a/cloudera.com/document/d/14nqQXlIvgJOxGFTfhSoquYzjW8Yx-v9TqTBqRjiB7g0/edit>
Cheers
On Thu, Jul 17, 2014 at 11:34 AM, Dima Spivak <ds...@cloudera.com> wrote:
> Aleks' jdiff script is jdiffHBasePublicAPI.sh and can be found in the
> top-level dev-support folder. On Github:
>
> https://github.com/apache/hbase/blob/master/dev-support/jdiffHBasePublicAPI.sh
>
> -Dima
>
>
> On Wed, Jul 16, 2014 at 7:57 PM, Ted Yu <yu...@gmail.com> wrote:
>
> > If I remember correctly, Aleksandr Shulman has a JDiff tool that shows
> > difference between public APIs of two releases.
> > There is also spreadsheet showing what changed in 0.96 release.
> >
> > I will try to find them.
> >
> > Cheers
> >
> >
> > On Wed, Jul 16, 2014 at 7:34 PM, Michael.Calvin <77...@qq.com> wrote:
> >
> > > Yes, It works , thank you very much.
> > > And I also find out custom filter needs to be serialized and then
> > > deserialized to work properly. That means I still need to find who
> > > serialized it and how the parameters serialized.
> > >
> > >
> > > I just want to know one more thing:
> > > Who the Fxxk is responsible for NEVER EVER mentioning this ?
> > >
> > >
> > > ------------------
> > > Michael.Calvin.Shi
> > >
> > >
> > > Ted Yu <yu...@...> writes:
> > >
> > >
> > > >
> > > > Please implement this method in YourFilter:
> > > >
> > > > public static YourFilter parseFrom(final byte [] pbBytes) throws
> > > > DeserializationException {
> > > >
> > > > You can refer to SingleColumnValueFilter for an example.
> > > >
> > > > Cheers
> > > >
> >
>
Re: RE： RE： re： What's the exact procedure of making a custom filter work?
Posted by Dima Spivak <ds...@cloudera.com>.
Aleks' jdiff script is jdiffHBasePublicAPI.sh and can be found in the
top-level dev-support folder. On Github:
https://github.com/apache/hbase/blob/master/dev-support/jdiffHBasePublicAPI.sh
-Dima
On Wed, Jul 16, 2014 at 7:57 PM, Ted Yu <yu...@gmail.com> wrote:
> If I remember correctly, Aleksandr Shulman has a JDiff tool that shows
> difference between public APIs of two releases.
> There is also spreadsheet showing what changed in 0.96 release.
>
> I will try to find them.
>
> Cheers
>
>
> On Wed, Jul 16, 2014 at 7:34 PM, Michael.Calvin <77...@qq.com> wrote:
>
> > Yes, It works , thank you very much.
> > And I also find out custom filter needs to be serialized and then
> > deserialized to work properly. That means I still need to find who
> > serialized it and how the parameters serialized.
> >
> >
> > I just want to know one more thing:
> > Who the Fxxk is responsible for NEVER EVER mentioning this ?
> >
> >
> > ------------------
> > Michael.Calvin.Shi
> >
> >
> > Ted Yu <yu...@...> writes:
> >
> >
> > >
> > > Please implement this method in YourFilter:
> > >
> > > public static YourFilter parseFrom(final byte [] pbBytes) throws
> > > DeserializationException {
> > >
> > > You can refer to SingleColumnValueFilter for an example.
> > >
> > > Cheers
> > >
>
Re: RE： RE： re： What's the exact procedure of making a custom filter work?
Posted by Ted Yu <yu...@gmail.com>.
If I remember correctly, Aleksandr Shulman has a JDiff tool that shows
difference between public APIs of two releases.
There is also spreadsheet showing what changed in 0.96 release.
I will try to find them.
Cheers
On Wed, Jul 16, 2014 at 7:34 PM, Michael.Calvin <77...@qq.com> wrote:
> Yes, It works , thank you very much.
> And I also find out custom filter needs to be serialized and then
> deserialized to work properly. That means I still need to find who
> serialized it and how the parameters serialized.
>
>
> I just want to know one more thing:
> Who the Fxxk is responsible for NEVER EVER mentioning this ?
>
>
> ------------------
> Michael.Calvin.Shi
>
>
> Ted Yu <yu...@...> writes:
>
>
> >
> > Please implement this method in YourFilter:
> >
> > public static YourFilter parseFrom(final byte [] pbBytes) throws
> > DeserializationException {
> >
> > You can refer to SingleColumnValueFilter for an example.
> >
> > Cheers
> >
RE： RE： re： What's the exact procedure of making a custom filter work?
Posted by "Michael.Calvin" <77...@qq.com>.
Yes, It works , thank you very much.
And I also find out custom filter needs to be serialized and then deserialized to work properly. That means I still need to find who serialized it and how the parameters serialized.
I just want to know one more thing:
Who the Fxxk is responsible for NEVER EVER mentioning this ?
------------------
Michael.Calvin.Shi
Ted Yu <yu...@...> writes:
>
> Please implement this method in YourFilter:
>
> public static YourFilter parseFrom(final byte [] pbBytes) throws
> DeserializationException {
>
> You can refer to SingleColumnValueFilter for an example.
>
> Cheers
>
Re: RE： re： What's the exact procedure of making a custom filter work?
Posted by Ted Yu <yu...@gmail.com>.
Please implement this method in YourFilter:
public static YourFilter parseFrom(final byte [] pbBytes) throws
DeserializationException {
You can refer to SingleColumnValueFilter for an example.
Cheers
On Wed, Jul 16, 2014 at 2:18 AM, 神之疯神 <77...@qq.com> wrote:
> No. And that exception is never thrown.
> But this inspired me:
> I override every method in filterbase with "throw new IOException("what
> the hell");".
> Guess what?
> Nothing happened.
>
>
> ------------------
> Michael.Calvin.Shi
>
>
>
> Ted Yu <yu...@...> writes:
>
>
> >
> > createFilterFromArguments() in FilterBase throws exception.
> >
> > Have you overridden this method ?
> >
> > Cheers
> >
> > On Jul 16, 2014, at 1:26 AM, "Michael.Calvin" <77...@...> wrote:
> >
RE： re： What's the exact procedure of making a custom filter work?
Posted by 神之疯神 <77...@qq.com>.
No. And that exception is never thrown.
But this inspired me:
I override every method in filterbase with "throw new IOException("what the hell");".
Guess what?
Nothing happened.
------------------
Michael.Calvin.Shi
Ted Yu <yu...@...> writes:
>
> createFilterFromArguments() in FilterBase throws exception.
>
> Have you overridden this method ?
>
> Cheers
>
> On Jul 16, 2014, at 1:26 AM, "Michael.Calvin" <77...@...> wrote:
>
RE： What's the exact procedure of making a custom filter work?
Posted by "Michael.Calvin" <77...@qq.com>.
THERE IS NO ABSTRACT METHODS IN FILTERBASE AT VERSION 0.98.
And please read this, if you don't have time to see the source code:
/**
* Abstract base class to help you implement new Filters. Common "ignore" or NOOP type
* methods can go here, helping to reduce boiler plate in an ever-expanding filter
* library.
*
* If you could instantiate FilterBase, it would end up being a "null" filter -
* that is one that never filters anything.
*/
Dima Spivak <ds...@...> writes:
>
> Michael,
>
> FilterBase extends Filter, which has its own abstract methods that need
> implementation in a concrete class. Or am I missing something? :)
>
> -Dima
>
------------------
Michael.Calvin.Shi
Re: What's the exact procedure of making a custom filter work?
Posted by Dima Spivak <ds...@cloudera.com>.
Michael,
FilterBase extends Filter, which has its own abstract methods that need
implementation in a concrete class. Or am I missing something? :)
-Dima
On Wednesday, July 16, 2014, Ted Yu <yu...@gmail.com> wrote:
> createFilterFromArguments() in FilterBase throws exception.
>
> Have you overridden this method ?
>
> Cheers
>
> On Jul 16, 2014, at 1:26 AM, "Michael.Calvin" <77231541@qq.com
> <javascript:;>> wrote:
>
> > No. There isn't any abstract methods. And if there is any I wouldn't be
> able to compile it.
> >
> >
> > ------------------
> > Michael.Calvin.Shi
> >
> >
> >
> >
> >
> > Ted Yu <yu...@...> writes:
> >
> >
> >>
> >> FilterBase is abstract. Have you implemented the abstract methods ?
> >
> >
>
Re: re： What's the exact procedure of making a custom filter work?
Posted by Ted Yu <yu...@gmail.com>.
createFilterFromArguments() in FilterBase throws exception.
Have you overridden this method ?
Cheers
On Jul 16, 2014, at 1:26 AM, "Michael.Calvin" <77...@qq.com> wrote:
> No. There isn't any abstract methods. And if there is any I wouldn't be able to compile it.
>
>
> ------------------
> Michael.Calvin.Shi
>
>
>
>
>
> Ted Yu <yu...@...> writes:
>
>
>>
>> FilterBase is abstract. Have you implemented the abstract methods ?
>
>