[GitHub] [hudi] xushiyan commented on a change in pull request #4777: [HUDI-2931] Add config to disable table services

[GitBox <gi...@apache.org>]

xushiyan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806159392



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
##########
@@ -1142,7 +1152,13 @@ protected boolean scheduleCleaningAtInstant(String instantTime, Option<Map<Strin
 
   private Option<String> scheduleTableServiceInternal(String instantTime, Option<Map<String, String>> extraMetadata,
                                                       TableServiceType tableServiceType) {
+    if (!tableServicesEnabled(config)) {
+      return Option.empty();
+    }
     switch (tableServiceType) {
+      case ARCHIVE:
+        LOG.info("Scheduling archiving is not supported. Skipping.");

Review comment:
       @nsivabalan it's because `org.apache.hudi.common.model.TableServiceType` was updated to include ARCHIVE, so the switch should enumerate the list for completeness.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org