You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "wangsheng (Code Review)" <ge...@cloudera.org> on 2019/12/28 12:40:06 UTC
[Impala-ASF-CR] IMPALA-9268: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
wangsheng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14957
Change subject: IMPALA-9268: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
IMPALA-9268: Fix test_log_fragments.py test case failed after add
CreateKuduTableWithoutHMSTest.java
After add CreateKuduTableWithoutHMSTest.java in IMPALA-8974,
test_log_fragments.py test case failed while running exhaustive test in
jenkins. The main reason is CreateKuduTableWithoutHMSTest test case
restart the impala cluster without --log_dir. The solution is add start
parameter '--log_dir' to restart impala cluster.
Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
---
M fe/src/test/java/org/apache/impala/catalog/CreateKuduTableWithoutHMSTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/14957/2
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
[Impala-ASF-CR] IMPALA-9266: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9266: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
Patch Set 4: Code-Review+2
Thanks for the quick fix!
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 30 Dec 2019 02:01:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9268: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has abandoned this change. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9268: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
Abandoned
This bug will be solved in IMPALA-9266, IMPALA-9268 is duplicated
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9268: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9268: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
Patch Set 2:
> Abandoned
>
> This bug will be solved in IMPALA-9266, IMPALA-9268 is duplicated
Please modify the commit title and upload it for IMPALA-9266. Hope this can be fixed soon.
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Dec 2019 01:12:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9266: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14957
to look at the new patch set (#4).
Change subject: IMPALA-9266: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
IMPALA-9266: Fix test_log_fragments.py test case failed after add
CreateKuduTableWithoutHMSTest.java
After add CreateKuduTableWithoutHMSTest.java in IMPALA-8974,
test_log_fragments.py test case failed while running exhaustive test in
jenkins. The main reason is CreateKuduTableWithoutHMSTest test case
restart the impala cluster without --log_dir. The solution is add start
parameter '--log_dir' to restart impala cluster.
Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
---
M fe/src/test/java/org/apache/impala/catalog/CreateKuduTableWithoutHMSTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/14957/4
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9266: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9266: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
Patch Set 5:
> Patch Set 4: Code-Review-1
>
> This is not a good way to fix it. log_dir is not the only argument that we pass to start-impala-cluster.py for some test configurations, so this makes it look like it is ok, when it really isn't. One of our test configurations enables the datacache by adding the data_cache_dir + data_cache_size + always_use_data_cache to the arguments of start-impala-cluster.py. This restarts Impala without those arguments, making it a different test configuration.
>
> I would rather disable this test for now.
Sorry that this already got merged... Hopefully, it can make some Jenkins jobs grean for some time.
I think we should rewrite this test to be similar as other custom cluster test. It breaks our rule "New tests should be created in areas similar to existing tests" in https://cwiki.apache.org/confluence/display/IMPALA/How+to+load%2C+run%2C+and+create+new+Impala+tests
Actually there're no needs to write this in FE tests. It's also a burden to maintain two test frameworks for custom cluster tests.
Sheng, could you please rewrite your test using the existing test framework? tests/custom_cluster/test_custom_hive_configs.py is an example for testing customized hive configs. Please rewrite your test into this file.
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 30 Dec 2019 08:57:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9268: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9268: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5344/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 28 Dec 2019 13:10:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9266: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14957
to look at the new patch set (#3).
Change subject: IMPALA-9266: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
IMPALA-9266: Fix test_log_fragments.py test case failed after add
CreateKuduTableWithoutHMSTest.java
After add CreateKuduTableWithoutHMSTest.java in IMPALA-8974,
test_log_fragments.py test case failed while running exhaustive test in
jenkins. The main reason is CreateKuduTableWithoutHMSTest test case
restart the impala cluster without --log_dir. The solution is add start
parameter '--log_dir' to restart impala cluster.
Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
---
M fe/src/test/java/org/apache/impala/catalog/CreateKuduTableWithoutHMSTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/14957/3
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 3
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9266: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9266: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 30 Dec 2019 06:31:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9266: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9266: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5372/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 30 Dec 2019 02:01:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9266: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9266: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
Patch Set 4:
> > Abandoned
> >
> > This bug will be solved in IMPALA-9266, IMPALA-9268 is duplicated
>
> Please modify the commit title and upload it for IMPALA-9266. Hope
> this can be fixed soon.
Thanks for your advice, Quanlong, I modified this patch for IMPALA-9266, and run exhaustive test yesterday, all test cases passed, here is the Jenkins url: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/9430/
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 30 Dec 2019 01:54:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9266: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9266: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
Patch Set 4: Code-Review-1
This is not a good way to fix it. log_dir is not the only argument that we pass to start-impala-cluster.py for some test configurations, so this makes it look like it is ok, when it really isn't. One of our test configurations enables the datacache by adding the data_cache_dir + data_cache_size + always_use_data_cache to the arguments of start-impala-cluster.py. This restarts Impala without those arguments, making it a different test configuration.
I would rather disable this test for now.
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 30 Dec 2019 05:32:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9268: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has restored this change. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9268: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
Restored
Modify for IMPALA-9266
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9266: Fix test log fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14957 )
Change subject: IMPALA-9266: Fix test_log_fragments.py test case failed after add CreateKuduTableWithoutHMSTest.java
......................................................................
IMPALA-9266: Fix test_log_fragments.py test case failed after add
CreateKuduTableWithoutHMSTest.java
After add CreateKuduTableWithoutHMSTest.java in IMPALA-8974,
test_log_fragments.py test case failed while running exhaustive test in
jenkins. The main reason is CreateKuduTableWithoutHMSTest test case
restart the impala cluster without --log_dir. The solution is add start
parameter '--log_dir' to restart impala cluster.
Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Reviewed-on: http://gerrit.cloudera.org:8080/14957
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/catalog/CreateKuduTableWithoutHMSTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
Objections:
Joe McDonnell: I would prefer this is not merged as is
--
To view, visit http://gerrit.cloudera.org:8080/14957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Gerrit-Change-Number: 14957
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>