You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/23 18:23:37 UTC

[GitHub] [beam] mszb commented on a change in pull request #11210: [BEAM-8949] SpannerIO integration tests

mszb commented on a change in pull request #11210:
URL: https://github.com/apache/beam/pull/11210#discussion_r414016644



##########
File path: sdks/python/apache_beam/io/gcp/experimental/spannerio.py
##########
@@ -1008,31 +1007,30 @@ def _reset_count(self):
     self._cells = 0
 
   def process(self, element):
-    mg_info = element.info
+    for elem in element:

Review comment:
       I've updated the batch process to support the dataflow runner. The process is almost the same as the previous commit but now I've added the `ToList()` combine transform before passing the mutation groups from to the `_BatchFn` to create batches.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org