You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "w41ter (via GitHub)" <gi...@apache.org> on 2026/04/09 08:15:37 UTC
[PR] [fix](cloud) Add predecessor instance id [doris]
w41ter opened a new pull request, #62276:
URL: https://github.com/apache/doris/pull/62276
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
When a rollback exists, the predecessor instance is not the same as the source instance. This change separates the two semantics into distinct fields for clarity.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Add predecessor instance id [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62276:
URL: https://github.com/apache/doris/pull/62276#issuecomment-4219881810
# Cloud UT Coverage Report
Increment line coverage `100.00% (6/6)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/abf3b97fa02e6cd4dd1d01f1af2cf25d6b9f2e76_abf3b97fa02e6cd4dd1d01f1af2cf25d6b9f2e76_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/abf3b97fa02e6cd4dd1d01f1af2cf25d6b9f2e76_abf3b97fa02e6cd4dd1d01f1af2cf25d6b9f2e76_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.48% (1798/2291) |
| Line Coverage | 64.12% (32283/50345) |
| Region Coverage | 65.08% (16249/24967) |
| Branch Coverage | 55.58% (8681/15620) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Add predecessor instance id [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62276:
URL: https://github.com/apache/doris/pull/62276#discussion_r3056610290
##########
cloud/src/resource-manager/resource_manager.cpp:
##########
@@ -1414,18 +1414,19 @@ std::pair<MetaServiceCode, std::string> ResourceManager::refresh_instance(
void ResourceManager::refresh_instance(const std::string& instance_id,
const InstanceInfoPB& instance) {
bool is_successor_instance = instance.has_original_instance_id();
- std::string source_instance_id = is_successor_instance ? instance.source_instance_id() : "";
+ std::string predecessor_instance_id =
+ is_successor_instance ? instance.predecessor_instance_id() : "";
std::lock_guard l(mtx_);
for (auto i = node_info_.begin(); i != node_info_.end();) {
- // erase all nodes not belong to this instance_id
- if (i->second.instance_id != instance_id &&
- // ... or, if is_successor_instance, erase nodes belong to source_instance_id
- (!is_successor_instance || i->second.instance_id != source_instance_id)) {
+ // erase all nodes belong to this instance_id
+ if (i->second.instance_id == instance_id ||
Review Comment:
This switches cache eviction from `source_instance_id` to `predecessor_instance_id`, but I can't find any writer for the new field in the rollback flow. The current chain/rollback paths and the existing `RollbackInstance` test still populate only `source_instance_id` and `original_instance_id`. In that path, refreshing the rollback target stops removing the predecessor's cached nodes, so `get_node()` can return both old and new entries for the same `cloud_unique_id` until the predecessor is refreshed separately. `get_instance_id()` then logs a one-to-many warning and picks the last entry. Please either populate `predecessor_instance_id` everywhere a rollback successor is created, or keep the old fallback here until all producers are updated and tested.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Add predecessor instance id [doris]
Posted by "w41ter (via GitHub)" <gi...@apache.org>.
w41ter commented on PR #62276:
URL: https://github.com/apache/doris/pull/62276#issuecomment-4212666490
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Add predecessor instance id [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62276:
URL: https://github.com/apache/doris/pull/62276#issuecomment-4212995225
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Add predecessor instance id [doris]
Posted by "w41ter (via GitHub)" <gi...@apache.org>.
w41ter commented on PR #62276:
URL: https://github.com/apache/doris/pull/62276#issuecomment-4219592540
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Add predecessor instance id [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #62276:
URL: https://github.com/apache/doris/pull/62276#issuecomment-4212665560
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Add predecessor instance id [doris]
Posted by "w41ter (via GitHub)" <gi...@apache.org>.
w41ter merged PR #62276:
URL: https://github.com/apache/doris/pull/62276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Add predecessor instance id [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62276:
URL: https://github.com/apache/doris/pull/62276#issuecomment-4220168142
# FE UT Coverage Report
Increment line coverage `` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62276_abf3b97fa02e6cd4dd1d01f1af2cf25d6b9f2e76/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62276_abf3b97fa02e6cd4dd1d01f1af2cf25d6b9f2e76/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Add predecessor instance id [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62276:
URL: https://github.com/apache/doris/pull/62276#issuecomment-4221357899
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62276_abf3b97fa02e6cd4dd1d01f1af2cf25d6b9f2e76_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62276_abf3b97fa02e6cd4dd1d01f1af2cf25d6b9f2e76_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.88% (26729/37186) |
| Line Coverage | 54.88% (283186/516056) |
| Region Coverage | 51.89% (234429/451781) |
| Branch Coverage | 53.36% (101399/190041) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Add predecessor instance id [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62276:
URL: https://github.com/apache/doris/pull/62276#issuecomment-4212994983
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org