You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/05 14:08:21 UTC
[GitHub] [iceberg] nastra commented on a diff in pull request #4610: Nessie: Support Namespace properties
nastra commented on code in PR #4610:
URL: https://github.com/apache/iceberg/pull/4610#discussion_r865948908
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -223,16 +223,16 @@ public boolean dropNamespace(Namespace namespace) throws NamespaceNotEmptyExcept
@Override
public boolean setProperties(Namespace namespace, Map<String, String> properties) {
- throw new UnsupportedOperationException(
- "Cannot set properties for namespace '" + namespace +
- "': setProperties is not supported by the NessieCatalog");
+ client.setProperties(namespace, properties);
Review Comment:
I might change this in a follow-up PR and move the boolean into `NessieIcebergClient#setProperties(..)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org