[jira] [Work logged] (HIVE-17314) LazySimpleSerializeWrite.writeString() contains if with an empty body

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-17314?focusedWorklogId=446689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446689 ]

ASF GitHub Bot logged work on HIVE-17314:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jun/20 16:54
            Start Date: 16/Jun/20 16:54
    Worklog Time Spent: 10m 
      Work Description: github-actions[bot] commented on pull request #234:
URL: https://github.com/apache/hive/pull/234#issuecomment-644887032


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 446689)
    Remaining Estimate: 0h
            Time Spent: 10m

> LazySimpleSerializeWrite.writeString() contains if with an empty body
> ---------------------------------------------------------------------
>
>                 Key: HIVE-17314
>                 URL: https://issues.apache.org/jira/browse/HIVE-17314
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Assignee: Oleg Danilov
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17314.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Looking at the LazySimpleSerializeWrite.java I found odd 'if':
> Lines 234-235:
> {code:java}
>     if (v.equals(nullSequenceBytes)) {
>     }
> {code}
> Seems like either something is missed there or this 'if' could be dropped out.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)