You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/07/19 12:39:00 UTC
[jira] [Commented] (DISPATCH-1568) add c-unittest support
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160666#comment-17160666 ]
ASF GitHub Bot commented on DISPATCH-1568:
------------------------------------------
jiridanek commented on pull request #684:
URL: https://github.com/apache/qpid-dispatch/pull/684#issuecomment-660637421
I've been thinking about this some:
Support for RHEL 6 / CentOS 6 by the vendor ends at the end of this year (2020) and it is possible to get a C++11 compatible compiler from Software Collections (there is gcc 4.8, if I recall correctly), even on CentOS 6. Therefore, I'd go for doctest 2.4.0, instead for the C++98 compatible branch.
I'd merge this in two stages. I am unsure about the mocking part, personally. So I'd merge the nonmocking part first, and add the rest later.
I was thinking about merging #294 and I was thinking that it deserves to have a test. Then I realized we still don't have the doctest PR merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> add c-unittest support
> ----------------------
>
> Key: DISPATCH-1568
> URL: https://issues.apache.org/jira/browse/DISPATCH-1568
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Reporter: Nicolas
> Priority: Major
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Right now we are not using any framework for easily write c unit-test when developing (or later).
> The idea is to research available libraries, pick one and try to include in our workflow.
> preliminary candidates:
> [https://github.com/google/googletest]
> [https://github.com/catchorg/Catch2]
> [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Clients using this one (old catch2)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org