You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaka11chen (via GitHub)" <gi...@apache.org> on 2023/04/26 08:24:45 UTC
[GitHub] [doris] kaka11chen opened a new pull request, #19106: [Optimize](parquet-reader) Opt by filtering null count statistics in the row group and page level.
kaka11chen opened a new pull request, #19106:
URL: https://github.com/apache/doris/pull/19106
# Proposed changes
Issue Number: About #19038, we found in this case, `l_orderkey` has many nulls, so we can filter it by null count statistics in the row group and page level, then it can improve a lot of performance in this case.
## Test Result:
Before opt:
```
mysql> select l_quantity from test_external_catalog_hive.tpch_1000_parquet.lineitem where l_orderkey = 599614241 and l_partkey = 59018738 and l_suppkey = 1518744 limit 2;
+------------+
| l_quantity |
+------------+
| 16.00 |
+------------+
1 row in set (41.95 sec)
```
After opt:
```
mysql> select l_quantity from test_external_catalog_hive.tpch_1000_parquet.lineitem where l_orderkey = 599614241 and l_partkey = 59018738 and l_suppkey = 1518744 limit 2;
+------------+
| l_quantity |
+------------+
| 16.00 |
+------------+
1 row in set (4.32 sec)
```
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] AshinGau commented on pull request #19106: [Optimize](parquet-reader) Opt by filtering null count statistics in the row group and page level.
Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on PR #19106:
URL: https://github.com/apache/doris/pull/19106#issuecomment-1525687661
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #19106: [Optimize](parquet-reader) Opt by filtering null count statistics in the row group and page level.
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #19106:
URL: https://github.com/apache/doris/pull/19106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] kaka11chen commented on pull request #19106: [Optimize](parquet-reader) Opt by filtering null count statistics in the row group and page level.
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #19106:
URL: https://github.com/apache/doris/pull/19106#issuecomment-1523041574
run buildalll
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19106: [Optimize](parquet-reader) Opt by filtering null count statistics in the row group and page level.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19106:
URL: https://github.com/apache/doris/pull/19106#issuecomment-1523003020
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org