You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/27 06:41:01 UTC
[GitHub] williaster opened a new pull request #5296: [dashboard v2] add
`` component
williaster opened a new pull request #5296: [dashboard v2] add `<MissingChart />` component
URL: https://github.com/apache/incubator-superset/pull/5296
This PR adds a `<MissingChart />` component that is shown in the case that a dashboard v2 `<Chart />` component has no slice definition.
**Testing**
- verified that this works in the case that a layout references a chart that was deleted (and previously part of the dashboard)
- Added frontend tests for `<MissingChart />`
- Tested undo/redo of removing the empty chart, adds toast when we add a slice that has no definition to a dashboard
@graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org