You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael Busch (JIRA)" <ji...@apache.org> on 2009/10/13 18:47:31 UTC
[jira] Created: (LUCENE-1979) Remove remaining deprecations from
indexer package
Remove remaining deprecations from indexer package
--------------------------------------------------
Key: LUCENE-1979
URL: https://issues.apache.org/jira/browse/LUCENE-1979
Project: Lucene - Java
Issue Type: Task
Components: Index
Reporter: Michael Busch
Priority: Minor
Fix For: 3.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765427#action_12765427 ]
Michael Busch commented on LUCENE-1979:
---------------------------------------
Also added an appropriate entry to the bw breaks section of CHANGES.txt.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765408#action_12765408 ]
Michael Busch commented on LUCENE-1979:
---------------------------------------
Hi Uwe,
thanks for taking a look here. However, there *is* a problem. Please see my previous comment with the exception I'm getting when running test-tag. It seems like I have to commit the change to SnapshotDeletionPolicy#snaphot() also to the bw branch.
{quote}
Can you apply the undeprecations also to 2.9 branch?
{quote}
Will do!
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765414#action_12765414 ]
Uwe Schindler commented on LUCENE-1979:
---------------------------------------
There are two possibilities:
- Changing the backwards branch main code to change this method
- remove this test
I think both possibilities has pros and cons, I tend to the first, because: As you changed the method also in 3.0 trunk, you have to put a backwards incompatibility entry into changes.txt (because we have detected it with the test).
(I only looked over the patch, but didn't test it, to find the same things like yesterday. Didn't read all the comments, sorry).
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch updated LUCENE-1979:
----------------------------------
Attachment: LUCENE-1979-2.patch
Fixes the bug in TermVectorAccessor.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765593#action_12765593 ]
Uwe Schindler commented on LUCENE-1979:
---------------------------------------
My patch has a bug in TestTermVectorAccessor in contrib/misc (rewrite from deprec TermEnum.skip). I do not know whats wrong. Maybe you can fix it, I can look after it later in the evening.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-1979:
----------------------------------
Attachment: LUCENE-1979-2-bw.patch
LUCENE-1979-2.patch
Here the patch for the rest. It also needs a changed backwards branch.
I have to leave now to Zurich will be back on Friday, but may have some time to look further into it. Michael, can you check the whole patch, I am on a hurry and was not able to test everything (trunk, trunk-contrib, bw).
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765433#action_12765433 ]
Uwe Schindler commented on LUCENE-1979:
---------------------------------------
I think you missed to delete IndexComitPoint in SVN.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765459#action_12765459 ]
Uwe Schindler commented on LUCENE-1979:
---------------------------------------
javac only shows a warning, if you override a deprecated method and not deprecate it or if you use a deprecated method. But it does not tell you that there are deprecated methods declared.
I will post a patch with the rest removed.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch resolved LUCENE-1979.
-----------------------------------
Resolution: Fixed
Committed revision 825022.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch updated LUCENE-1979:
----------------------------------
Attachment: lucene-1979.patch
Removes almost all deprecations from the indexer package. The only things left are:
* IndexReader#getFieldCacheKey() - what do we do with that one?
* calls to IndexInput#readChars() and #skipChars() - I think we have to keep those until 4.0?
All core & contrib tests pass. It'd be good if someone could review this patch though.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765316#action_12765316 ]
Michael McCandless commented on LUCENE-1979:
--------------------------------------------
bq. IndexReader#getFieldCacheKey() - what do we do with that one?
I think we should undeprecate it. I had deprecated it thinking LUCENE-831 would land.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765679#action_12765679 ]
Uwe Schindler commented on LUCENE-1979:
---------------------------------------
Thanks!
Your patch for TermVectorAccessor is fine, only the termEnum.close() should also be inside the if-branch.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765407#action_12765407 ]
Uwe Schindler commented on LUCENE-1979:
---------------------------------------
Hi Michael,
I see no problem in bw patch :-) One other thing: Can you apply the undeprecations also to 2.9 branch? (Like I did yesterday for the Searchable one).
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765416#action_12765416 ]
Michael Busch commented on LUCENE-1979:
---------------------------------------
Well IndexCommitPoint was deprecated, so I think this is an expected break - so I don't think an entry in CHANGES.txt is necessary?
I'm also for the first option. Will do that.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1979) Remove remaining
deprecations from indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765414#action_12765414 ]
Uwe Schindler edited comment on LUCENE-1979 at 10/13/09 10:59 PM:
------------------------------------------------------------------
There are two possibilities:
- Changing the backwards branch main code to change this method
- remove this test
I think both possibilities has pros and cons, I tend to the first, because: As you changed the method also in 3.0 trunk, you have to put a backwards incompatibility entry into changes.txt (because we have detected it with the test). In this case it is also valid to change the bw branch code and not only tests.
(I only looked over the patch, but didn't test it, to find the same things like yesterday. Didn't read all the comments, sorry).
was (Author: thetaphi):
There are two possibilities:
- Changing the backwards branch main code to change this method
- remove this test
I think both possibilities has pros and cons, I tend to the first, because: As you changed the method also in 3.0 trunk, you have to put a backwards incompatibility entry into changes.txt (because we have detected it with the test).
(I only looked over the patch, but didn't test it, to find the same things like yesterday. Didn't read all the comments, sorry).
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch updated LUCENE-1979:
----------------------------------
Attachment: LUCENE-1979-2-bw.patch
And the fix for the bw-branch.
Running all tests again now...
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1979) Remove remaining
deprecations from indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765679#action_12765679 ]
Uwe Schindler edited comment on LUCENE-1979 at 10/14/09 11:43 AM:
------------------------------------------------------------------
Thanks!
-Your patch for TermVectorAccessor is fine, only the termEnum.close() should also be inside the if-branch.-
EDIT: sorry, my fault.
was (Author: thetaphi):
Thanks!
Your patch for TermVectorAccessor is fine, only the termEnum.close() should also be inside the if-branch.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765320#action_12765320 ]
Michael Busch commented on LUCENE-1979:
---------------------------------------
OK, will do!
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765454#action_12765454 ]
Michael Busch commented on LUCENE-1979:
---------------------------------------
For now I fixed all those that the compiler showed me as warnings.
I think we should do a text search for "deprecated" on the entire core after the compiler warnings are removed.
But not now, going to bed...
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765701#action_12765701 ]
Uwe Schindler commented on LUCENE-1979:
---------------------------------------
+1 all tests pass here, too!
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765752#action_12765752 ]
Michael Busch commented on LUCENE-1979:
---------------------------------------
Shall I commit it or are you going to, Uwe? Just asking, so that we're not trying to do it at the same time...
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765336#action_12765336 ]
Michael McCandless commented on LUCENE-1979:
--------------------------------------------
bq. Is it correct that we keep IndexInput#readChars() and IndexInput#skipChars() for index format compatibility?
Yes, we need to keep them.
It was in 2.4 (LUCENE-510) when we switched to writing strings as UTF8, so any index created by eg 2.3 (which we must be able to read through at least 3.9) will need these methods.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch updated LUCENE-1979:
----------------------------------
Attachment: lucene-1979.patch
Same patch as before, but with IndexReader#getFieldCacheKey() undeprecated.
Is it correct that we keep IndexInput#readChars() and IndexInput#skipChars() for index format compatibility?
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1979) Remove remaining
deprecations from indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765483#action_12765483 ]
Uwe Schindler edited comment on LUCENE-1979 at 10/14/09 2:29 AM:
-----------------------------------------------------------------
Here the patch for the rest. It also needs a changed backwards branch. It also adds varargs to some of the addIndexes methods. We should look at other places, too, where to add varargs, too (e.g. IndexSearcher, MultiSearcher,...)
I have to leave now to Zurich will be back on Friday, but may have some time to look further into it. Michael, can you check the whole patch, I am on a hurry and was not able to test everything (trunk, trunk-contrib, bw).
was (Author: thetaphi):
Here the patch for the rest. It also needs a changed backwards branch.
I have to leave now to Zurich will be back on Friday, but may have some time to look further into it. Michael, can you check the whole patch, I am on a hurry and was not able to test everything (trunk, trunk-contrib, bw).
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765417#action_12765417 ]
Uwe Schindler commented on LUCENE-1979:
---------------------------------------
I would add the change in CHANGES.txt, too. Its only one line like: "Changed return value of snapshot() from X to Y". Because, if you use it, you cannot do drop in replacements, what you are able to do if you remove all deprecated code from your app in 2.9.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765611#action_12765611 ]
Michael Busch commented on LUCENE-1979:
---------------------------------------
This one fails in the bw-branch: org.apache.lucene.index.TestThreadedOptimize
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch resolved LUCENE-1979.
-----------------------------------
Resolution: Fixed
Committed revision 825288.
Thanks, Uwe!
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765753#action_12765753 ]
Uwe Schindler commented on LUCENE-1979:
---------------------------------------
do it!
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch updated LUCENE-1979:
----------------------------------
Attachment: lucene-1979-bw.patch
Patch for the back-compat trunk.
Hmm, everything passes, except this one:
{noformat}
[junit] java.lang.NoSuchMethodError: org.apache.lucene.index.SnapshotDeletionPolicy.snapshot()Lorg/apache/lucene/index/IndexCommitPoint;
[junit] at org.apache.lucene.TestSnapshotDeletionPolicy.testReuseAcrossWriters(TestSnapshotDeletionPolicy.java:82)
[junit] at org.apache.lucene.util.LuceneTestCase.runBare(LuceneTestCase.java:206)
[junit] Test org.apache.lucene.TestSnapshotDeletionPolicy FAILED
{noformat}
Here drop-in replacement doesn't seem to work. The method snapshot() of SnapshotDeletionPolicy was changed to return IndexCommit instead of IndexCommitPoint. IndexCommit used to implement the deprecated IndexCommitPoint, which this patch removes.
So the tests are compiled against snapshot() returning IndexCommitPoint in the bw-branch, and when run against the method returning IndexCommit of trunk it fails with the exception above.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765610#action_12765610 ]
Michael Busch commented on LUCENE-1979:
---------------------------------------
I just ran all tests. test-contrib and test-tag both fail for me. I can look into it a bit later today...
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765683#action_12765683 ]
Uwe Schindler commented on LUCENE-1979:
---------------------------------------
Seems that in the bw branch one more docCount() was in the tests... Sorry. I just patched the bw branch with the trunk test patch :-)
Running tests now, too.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765338#action_12765338 ]
Michael Busch commented on LUCENE-1979:
---------------------------------------
OK, thanks for the confirmation. Then this patch removes all deprecations in indexer now.
I'll wait for comments about the back-compat patch from Uwe first. If I mess up the bw-branch again I'm afraid he'll get mad at me! :)
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Reopened: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler reopened LUCENE-1979:
-----------------------------------
I think there are some more deprecations (hidden). A search on deprecated finds some more files. E.g.:
- allowMinus1Position in IndexWriter, DocumentsWriter, DocInverterPerField (field and methods, not correctly marked deprecated).
- Also IndexReader has still lots of deprecations (e.g. doCommit())
- CheckIndex#PrintStream
- some MergePolicy methods
- IndexWriter#DEFAULT_MERGE_FACTOR, DEFAULT_MAX_MERGE_DOCS, docCount(), abort(), addIndexes()
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1979) Remove remaining deprecations from
indexer package
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765690#action_12765690 ]
Michael Busch commented on LUCENE-1979:
---------------------------------------
{quote}
Seems that in the bw branch one more docCount() was in the tests
{quote}
Yeah I just removed the line, because the variable wasn't actually used anywhere.
OK all tests passed (core, contrib, bw).
+1 for committing.
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
> Key: LUCENE-1979
> URL: https://issues.apache.org/jira/browse/LUCENE-1979
> Project: Lucene - Java
> Issue Type: Task
> Components: Index
> Reporter: Michael Busch
> Priority: Minor
> Fix For: 3.0
>
> Attachments: LUCENE-1979-2-bw.patch, LUCENE-1979-2-bw.patch, LUCENE-1979-2.patch, LUCENE-1979-2.patch, lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org